[gentoo-installer] partition mounting

[gentoo-installer] partition mounting

[Devils-Hawk]

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

There are IMHO currently 2 small problems with the way the partition
mounting is handled:

1.) It is not possible to mount a partition the installer recognizes as
unknown because it tries to call "mount -t unknown" which of course will
always fail. The attached fix does not really break something because if
mount recognizes the partition type it will succeed if it doesn't well
it will fail the same way it did before.

2.) It is possible to define Other partition types in the ncurses based
version and safe it to an installprofile.xml but it is not possible to
load such a profile because the self defined type is not a known type,
which results in the installer deleting the partition regardless of the
format or resize flags.


[-- Attachment #2: unknown_partition.patch --]
[-- Type: text/plain, Size: 697 bytes --]

diff -r -puN installer/src/GLIArchitectureTemplate.py installer_bkup/src/GLIArchitectureTemplate.py
--- installer/src/GLIArchitectureTemplate.py	2006-09-11 18:57:26.000000000 +0200
+++ installer_bkup/src/GLIArchitectureTemplate.py	2006-09-11 16:09:11.000000000 +0200
@@ -407,8 +407,6 @@ class ArchitectureTemplate:
 					if partition_type:
 						if partition_type == "fat32" or partition_type == "fat16": partition_type = "vfat"
 						partition_type = "-t " + partition_type + " "
-						if partition_type == "-t unknown ": partition_type = ""
-
 					parts_to_mount[mountpoint] = (mountopts, partition_type, tmp_partitions[partition]['devnode'])
 					
 				if partition_type == "linux-swap":

Re: [gentoo-installer] partition mounting

[Benjamin Urban]

On Sep 11, 2006, at 2:38 PM, Devils-Hawk wrote:

>
> diff -r -puN installer/src/GLIArchitectureTemplate.py  
> installer_bkup/src/GLIArchitectureTemplate.py
> --- installer/src/GLIArchitectureTemplate.py	2006-09-11  
> 18:57:26.000000000 +0200
> +++ installer_bkup/src/GLIArchitectureTemplate.py	2006-09-11  
> 16:09:11.000000000 +0200
> @@ -407,8 +407,6 @@ class ArchitectureTemplate:
>  					if partition_type:
>  						if partition_type == "fat32" or partition_type == "fat16":  
> partition_type = "vfat"
>  						partition_type = "-t " + partition_type + " "
> -						if partition_type == "-t unknown ": partition_type = ""
> -
>  					parts_to_mount[mountpoint] = (mountopts, partition_type,  
> tmp_partitions[partition]['devnode'])
>  					
>  				if partition_type == "linux-swap":
>

Not that I'm one to nitpick or anything, but FYI your diff is  
reversed.  (I can never remember the correct order myself, so I  
probably shouldn't have said anything, but it needed to be said.)
-- 
gentoo-installer@gentoo.org mailing list

Re: [gentoo-installer] partition mounting

[Devils-Hawk]

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

Yep! I am sorry, just didn't pay attention. Correct patch attached.

Benjamin Urban wrote:
> 
> On Sep 11, 2006, at 2:38 PM, Devils-Hawk wrote:
> 
>>
>> diff -r -puN installer/src/GLIArchitectureTemplate.py
>> installer_bkup/src/GLIArchitectureTemplate.py
>> --- installer/src/GLIArchitectureTemplate.py    2006-09-11
>> 18:57:26.000000000 +0200
>> +++ installer_bkup/src/GLIArchitectureTemplate.py    2006-09-11
>> 16:09:11.000000000 +0200
>> @@ -407,8 +407,6 @@ class ArchitectureTemplate:
>>                      if partition_type:
>>                          if partition_type == "fat32" or
>> partition_type == "fat16": partition_type = "vfat"
>>                          partition_type = "-t " + partition_type + " "
>> -                        if partition_type == "-t unknown ":
>> partition_type = ""
>> -
>>                      parts_to_mount[mountpoint] = (mountopts,
>> partition_type, tmp_partitions[partition]['devnode'])
>>                     
>>                  if partition_type == "linux-swap":
>>
> 
> Not that I'm one to nitpick or anything, but FYI your diff is reversed. 
> (I can never remember the correct order myself, so I probably shouldn't
> have said anything, but it needed to be said.)
> --gentoo-installer@gentoo.org mailing list
> 
> 
> 


[-- Attachment #2: unknown_partition.patch --]
[-- Type: text/plain, Size: 694 bytes --]

diff -r -puN installer/src/GLIArchitectureTemplate.py installer_mod/src/GLIArchitectureTemplate.py
--- installer/src/GLIArchitectureTemplate.py	2006-09-12 14:44:00.000000000 +0200
+++ installer_mod/src/GLIArchitectureTemplate.py	2006-09-12 14:42:53.000000000 +0200
@@ -407,6 +407,8 @@ class ArchitectureTemplate:
 					if partition_type:
 						if partition_type == "fat32" or partition_type == "fat16": partition_type = "vfat"
 						partition_type = "-t " + partition_type + " "
+						if partition_type == "-t unknown ": partition_type = ""
+
 					parts_to_mount[mountpoint] = (mountopts, partition_type, tmp_partitions[partition]['devnode'])
 					
 				if partition_type == "linux-swap":

Re: [gentoo-installer] partition mounting

[Andrew Gaffney]

Devils-Hawk wrote:
> Yep! I am sorry, just didn't pay attention. Correct patch attached.
> 
> diff -r -puN installer/src/GLIArchitectureTemplate.py installer_mod/src/GLIArchitectureTemplate.py
> --- installer/src/GLIArchitectureTemplate.py	2006-09-12 14:44:00.000000000 +0200
> +++ installer_mod/src/GLIArchitectureTemplate.py	2006-09-12 14:42:53.000000000 +0200
> @@ -407,6 +407,8 @@ class ArchitectureTemplate:
>  					if partition_type:
>  						if partition_type == "fat32" or partition_type == "fat16": partition_type = "vfat"
>  						partition_type = "-t " + partition_type + " "
> +						if partition_type == "-t unknown ": partition_type = ""
> +
>  					parts_to_mount[mountpoint] = (mountopts, partition_type, tmp_partitions[partition]['devnode'])
>  					
>  				if partition_type == "linux-swap":

While this will "fix" the problem, it doesn't actually *fix* the problem of 
"unknown" partition types. I hope to have a better solution soon.

-- 
Andrew Gaffney                            http://dev.gentoo.org/~agaffney/
Gentoo Linux Developer                                   Installer Project
-- 
gentoo-installer@gentoo.org mailing list