public inbox for gentoo-installer@lists.gentoo.org
 help / color / mirror / Atom feed
From: Devils-Hawk <devilshawk@aon.at>
To: gentoo-installer@lists.gentoo.org
Subject: [gentoo-installer] partition mounting
Date: Mon, 11 Sep 2006 20:38:54 +0200	[thread overview]
Message-ID: <4505AD3E.9010507@aon.at> (raw)

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

There are IMHO currently 2 small problems with the way the partition
mounting is handled:

1.) It is not possible to mount a partition the installer recognizes as
unknown because it tries to call "mount -t unknown" which of course will
always fail. The attached fix does not really break something because if
mount recognizes the partition type it will succeed if it doesn't well
it will fail the same way it did before.

2.) It is possible to define Other partition types in the ncurses based
version and safe it to an installprofile.xml but it is not possible to
load such a profile because the self defined type is not a known type,
which results in the installer deleting the partition regardless of the
format or resize flags.


[-- Attachment #2: unknown_partition.patch --]
[-- Type: text/plain, Size: 697 bytes --]

diff -r -puN installer/src/GLIArchitectureTemplate.py installer_bkup/src/GLIArchitectureTemplate.py
--- installer/src/GLIArchitectureTemplate.py	2006-09-11 18:57:26.000000000 +0200
+++ installer_bkup/src/GLIArchitectureTemplate.py	2006-09-11 16:09:11.000000000 +0200
@@ -407,8 +407,6 @@ class ArchitectureTemplate:
 					if partition_type:
 						if partition_type == "fat32" or partition_type == "fat16": partition_type = "vfat"
 						partition_type = "-t " + partition_type + " "
-						if partition_type == "-t unknown ": partition_type = ""
-
 					parts_to_mount[mountpoint] = (mountopts, partition_type, tmp_partitions[partition]['devnode'])
 					
 				if partition_type == "linux-swap":


             reply	other threads:[~2006-09-11 18:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-11 18:38 Devils-Hawk [this message]
2006-09-12 11:49 ` [gentoo-installer] partition mounting Benjamin Urban
2006-09-12 12:49   ` Devils-Hawk
2006-09-12 13:08     ` Andrew Gaffney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4505AD3E.9010507@aon.at \
    --to=devilshawk@aon.at \
    --cc=gentoo-installer@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox