From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1PdTNv-0005sT-0P for garchives@archives.gentoo.org; Thu, 13 Jan 2011 20:03:03 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9D525E0857 for ; Thu, 13 Jan 2011 20:03:02 +0000 (UTC) Received: from atoth.sote.hu (atoth.sote.hu [195.111.75.211]) by pigeon.gentoo.org (Postfix) with ESMTP id 7E1D3E0762 for ; Thu, 13 Jan 2011 19:38:50 +0000 (UTC) Received: from atoth.sote.hu (apache@localhost [127.0.0.1]) by atoth.sote.hu (8.14.4/8.14.4/atoth@atoth.sote.hu) with ESMTP id p0DJcjrf027133 for ; Thu, 13 Jan 2011 20:38:45 +0100 X-DKIM: Sendmail DKIM Filter v2.8.3 atoth.sote.hu p0DJcjrf027133 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atoth.sote.hu; s=dwokfur; t=1294947529; bh=+sh6Ews7Fe1ViWIWZTtqreX17SAkIwTbYrTEmU4YPLc=; l=1467; h=Message-ID:Date:Subject:From:To:MIME-Version:Content-Type: Content-Transfer-Encoding; b=NkFDFOzuSlStAivoQ1YAHcT5Nt0JOUN7SZhGDtTvg8B2bMSmxS6chWN0WPYScNJU+ n3SJTCZHHAi9KhX2hd7AdJqX4hXwQC+dOSAT5+FpzGS5zQaikzFFaAGRXEODSoQ84q bRxpBNqKETpR/TDi9yDgKpyqjEMn0zvSdJZXq1+k= X-DomainKeys: Sendmail DomainKeys Filter v1.0.2 atoth.sote.hu p0DJcjrf027133 DomainKey-Signature: a=rsa-sha1; s=dwokfur; d=atoth.sote.hu; c=nofws; q=dns; h=x-virus-status:x-virus-scanned:received:message-id:date: subject:from:to:user-agent:mime-version:content-type: content-transfer-encoding:x-priority:importance:x-spam-status: x-spam-checker-version:x-list-milter:x-dcc-stat_fi_x86_64_virtual-metrics; b=NArF741Q+TjheF2wcuicgOdSv63ye9tRVSQ59uouowCe66RQLoIOFr7rI1Gbcoj33 5QJ4hNpg7MWUO4tC/OUadm1hYiG3nuPk0RD37bzAsRALDowmidG7bI3YHzpHXJ4bFvs gaJUl5ryK33gf1Pgb4CWsy899NVjw0DzK19zQTQ= X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.96.5 at atoth Received: from 10.97.100.79 (SquirrelMail authenticated user atoth) by atoth.sote.hu with HTTP; Thu, 13 Jan 2011 20:38:45 +0100 Message-ID: Date: Thu, 13 Jan 2011 20:38:45 +0100 Subject: [gentoo-hardened] hardened-sources-2.6.36-r8 From: =?utf-8?B?IlTDs3RoIEF0dGlsYSI=?= To: gentoo-hardened@lists.gentoo.org User-Agent: SquirrelMail/1.4.21 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-hardened@lists.gentoo.org Reply-to: gentoo-hardened@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain;charset=utf-8 X-Priority: 3 (Normal) Importance: Normal X-Spam-Status: No, score=-99.8 required=5.0 tests=ALL_TRUSTED,AWL, DKIM_ADSP_ALL,USER_IN_WHITELIST autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on atoth.sote.hu X-List-Milter: local mail X-DCC-STAT_FI_X86_64_VIRTUAL-Metrics: atoth; whitelist Content-Transfer-Encoding: quoted-printable X-Archives-Salt: d54a1df6-3e68-4ca0-b6f7-2682502f33a6 X-Archives-Hash: b940ee75ec0110cac1b895fe8831b47f Compiling the recent hardened-sources results in the following error message, when irda is enabled: CC net/irda/af_irda.o net/irda/af_irda.c: In function =E2=80=98__irda_getsockopt=E2=80=99: net/irda/af_irda.c:2289:4: error: label =E2=80=98out=E2=80=99 used but no= t defined The changes causing it introduced recently. --- linux-2.6.36-hardened-r7/net/irda/af_irda.c 2010-10-20 22:30:22.000000000 +0200 +++ linux-2.6.36-hardened-r8/net/irda/af_irda.c 2011-01-13 13:08:57.000000000 +0100 @@ -2278,6 +2278,17 @@ switch (optname) { case IRLMP_ENUMDEVICES: + + + /* Offset to first device entry */ + offset =3D sizeof(struct irda_device_list) - + sizeof(struct irda_device_info); + + if (len < offset) { + err =3D -EINVAL; + goto out; + } + /* Ask lmp for the current discovery log */ discoveries =3D irlmp_get_discoveries(&list.len, self->mask.word, self->nslots); @@ -2287,15 +2298,9 @@ err =3D 0; /* Write total list length back to client */ - if (copy_to_user(optval, &list, - sizeof(struct irda_device_list) - - sizeof(struct irda_device_info))) + if (copy_to_user(optval, &list, offset)) err =3D -EFAULT; - /* Offset to first device entry */ - offset =3D sizeof(struct irda_device_list) - - sizeof(struct irda_device_info); - /* Copy the list itself - watch for overflow */ if(list.len > 2048) { What are your suggestions? Thx: Dw. --=20 dr T=C3=B3th Attila, Radiol=C3=B3gus, 06-20-825-8057 Attila Toth MD, Radiologist, +36-20-825-8057