[gentoo-hardened] unicode use flag toggle

[gentoo-hardened] unicode use flag toggle

[William Throwe]

I'm curious, why was the unicode use flag toggled (off to on) recently
(past couple weeks) on hardened/linux/x86 ?  The only commit I see that
looks like it could have affected this has message "Avoid duplication of
USE flags in hardened profiles." which sounds like it wasn't supposed to
change any flag states.

Will

Re: [gentoo-hardened] unicode use flag toggle

[Anthony G. Basile]

On 02/20/2011 05:41 PM, William Throwe wrote:
> I'm curious, why was the unicode use flag toggled (off to on) recently
> (past couple weeks) on hardened/linux/x86 ?  The only commit I see that
> looks like it could have affected this has message "Avoid duplication of
> USE flags in hardened profiles." which sounds like it wasn't supposed to
> change any flag states.
> 
> Will

Looks like something is broken because all of the following hardened
profiles inherit from hardened/linux which has USE="-unicode" in
make.defaults.  They all exhibit the same behavior, namely they enable
unicode by default although they should not.

	hardened/linux/ia64
	hardened/linux/x86
	hardened/linux/amd64
	hardened/linux/powerpc/ppc32
	hardened/linux/powerpc/ppc64

I'll talk to the dev that made the change and see if we can get to the
bottom of why his change didn't work.  I don't want to start reverting
too soon because I'd like to understand what's going on first.

Sorry for the inconvenience to the community.

-- 
Anthony G. Basile, Ph.D.
Gentoo Developer

Re: [gentoo-hardened] unicode use flag toggle

[Anthony G. Basile]

On 02/20/2011 05:41 PM, William Throwe wrote:
> I'm curious, why was the unicode use flag toggled (off to on) recently
> (past couple weeks) on hardened/linux/x86 ?  The only commit I see that
> looks like it could have affected this has message "Avoid duplication of
> USE flags in hardened profiles." which sounds like it wasn't supposed to
> change any flag states.
> 
> Will

There was an issue with how hardened profile stacking was done.  This
became apparent when Arfrever cleaned up the duplicate USE flags.
Basically hardened/linux/x86 inherited from hardened/linux which
disabled unicode, but then inherited from releases/10.0 which re-enabled
it.  By moving the former inheritance down the list, the hardened/linux
profile had the last word.  This is how we want it even for other USE
flags, so changing the stack order was the right thing to do.

Please everyone, test the profiles!  Let me know asap if something bad
happens!  The same change was made to x86, amd64 multi/no-multi, ppc32,
ppc64 and ia64.  I tested all but ia64.

Finally Thanks William for pointing this out, but please open a bug next
time so we have a record in our bugzilla regarding what happened and how
we fixed it.

-- 
Anthony G. Basile, Ph.D.
Gentoo Developer