[gentoo-hardened] [PATCH] contrib/portage: Fix portage_ro_role interface

[gentoo-hardened] [PATCH] contrib/portage: Fix portage_ro_role interface

[Luis Ressel]

According to its documentation, portage_ro_role expects a role for $1
and a type for $2, just like other _role interfaces. However, the policy
directives inside the interface don't match its documentation and expect
$1 to be a type.

This interface isn't used anywhere in the policy, so no other fixes are
neccessary.
---
 policy/modules/contrib/portage.if | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/policy/modules/contrib/portage.if b/policy/modules/contrib/portage.if
index e9de28e..14c4fb6 100644
--- a/policy/modules/contrib/portage.if
+++ b/policy/modules/contrib/portage.if
@@ -406,13 +406,13 @@ interface(`portage_eselect_module',`
 ## </param>
 #
 interface(`portage_ro_role',`
-	portage_read_cache($1)
-	portage_read_config($1)
-	portage_read_db($1)
-	portage_read_ebuild($1)
-	portage_read_log($1)
-	portage_read_srcrepo($1)
-	portage_dontaudit_write_cache($1)
+	portage_read_cache($2)
+	portage_read_config($2)
+	portage_read_db($2)
+	portage_read_ebuild($2)
+	portage_read_log($2)
+	portage_read_srcrepo($2)
+	portage_dontaudit_write_cache($2)
 ')
 
 ########################################
-- 
2.6.2

Re: [gentoo-hardened] [PATCH] contrib/portage: Fix portage_ro_role interface

[Jason Zaman]

On Mon, Oct 19, 2015 at 02:04:06PM +0200, Luis Ressel wrote:
> According to its documentation, portage_ro_role expects a role for $1
> and a type for $2, just like other _role interfaces. However, the policy
> directives inside the interface don't match its documentation and expect
> $1 to be a type.
> 
> This interface isn't used anywhere in the policy, so no other fixes are
> neccessary.
> ---
>  policy/modules/contrib/portage.if | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

In master, thanks!