From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 4AB72158220 for ; Sun, 24 Nov 2024 22:47:38 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C89F0E09B8 for ; Sun, 24 Nov 2024 22:47:33 +0000 (UTC) Received: from sysrq.in (sysrq.in [37.79.202.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DE1ACE0E1D for ; Wed, 6 Jul 2022 00:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sysrq.in; s=sysrq.in; t=1657068543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GZgYt13n+LT/PhdSOjP1oZ1NkgW4CPyJ/zcjHUxF53U=; b=f3FPji+1tQA9KjPGXIA+WN1vR4LsazsrByKu1J04a7r62gIrbQScdmmnp8Arha/6XRtJgW OfA64MMUibtlaGd8ryG5uB/57nZaV26SZ0F23h/Rjn5rOsividsLL0g1RkRdPAfNIx4rzk EztFdQL3NMhhd2JrQum0nKq1xCNSo7cBAHCG79Tw9OC8+EK4C9on3wKL30K24oaanULlzS yIlPZBN18zjfVsCT+oyZbqqOWxeoI/P2myOp/A9BOWL3Wf4cShCEDdN8xNFCl7ZKbNA/tc y4D7VR13bm1JmFtPpyB6RMxm2yVbd71Aurg36UX9YzYv7gGooHuVff3uLwHAYQ== Received: from sysrq.in (localhost [127.0.0.1]) by sysrq.in (OpenSMTPD) with ESMTPSA id 0a8b7981 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Wed, 6 Jul 2022 00:49:03 +0000 (UTC) Date: Wed, 6 Jul 2022 05:49:02 +0500 From: Anna =?utf-8?B?4oCcQ3liZXJUYWlsb3LigJ0=?= To: gentoo-guru@lists.gentoo.org Subject: Re: [gentoo-guru] [RFC PATCH 2/3] eclass/R-packages: substitute _ with . in SRC_URI and HOMEPAGE Message-ID: References: <20220705071539.2463760-1-me@r0bert.dev> <010b0181cd377998-5a84d3c2-7078-4781-8d3c-cc7680888a85-000000@eu-west-2.amazonses.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Discussion on the GURU project and repository X-BeenThere: gentoo-guru@gentoo.org X-BeenThere: gentoo-guru@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <010b0181cd377998-5a84d3c2-7078-4781-8d3c-cc7680888a85-000000@eu-west-2.amazonses.com> Autocrypt: addr=cyber@sysrq.in; prefer-encrypt=mutual; keydata= mDMEYIFqhRYJKwYBBAHaRw8BAQdAmXuImZ3E4FYSZevE6xmeyqwBedA5TL3F0mA4nM8Jv5C0J0F ubmEg4oCcQ3liZXJUYWlsb3LigJ0gPGN5YmVyQHN5c3JxLmluPoiQBBMWCAA4FiEERA3R5VXjf5 x8ewz7f6gU36rhAzoFAmCBaoUCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQf6gU36rhA zoeCwD/UbmIjoaPHgxAubn/yoHbqtix0p1W8BwVdZSBinqtoc8BAMX19adz5Zx71lYFinFG7Yav D4E0jClMEfnYJH2TeG4HuDgEYIFqhRIKKwYBBAGXVQEFAQEHQGL1LYMPZDabnCTPEuyg5QgIlnU bKBqoPjp5sNidRZJXAwEIB4h4BBgWCAAgFiEERA3R5VXjf5x8ewz7f6gU36rhAzoFAmCBaoUCGw wACgkQf6gU36rhAzpFxwD/Z0QQGqLgBcafYUcHmzYcYxuyazuKWIn3H6OkeFUYtTgBAJmK2E+Yo mSMc0Ds93+yNQU0KhN1Ipyp9PiLDSSm8Z4B User-Agent: Mutt/2.2.6 (2022-06-05) X-Archives-Salt: 8f3cc6b5-31ab-447a-9214-91022d8b3f16 X-Archives-Hash: 6de679292fbb586490cefe52096e202f On 2022-07-05 07:16, Robert Greener wrote: > This is done throughout other parts of the eclass, it would mean that > the SRC_URI and HOMEPAGE wouldn't need to be overrided in the ebuilds. > For example, in the case of data.table. I'd introduce a new variable CRAN_PN instead. > Signed-off-by: Robert Greener > --- > eclass/R-packages.eclass | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/eclass/R-packages.eclass b/eclass/R-packages.eclass > index dd6b69933..a9bb32980 100644 > --- a/eclass/R-packages.eclass > +++ b/eclass/R-packages.eclass > @@ -22,10 +22,10 @@ esac > EXPORT_FUNCTIONS src_unpack src_prepare src_configure src_compile src_install pkg_postinst > > SRC_URI=" > - https://cran.r-project.org/src/contrib/${PN}_${PV}.tar.gz > - https://cran.r-project.org/src/contrib/Archive/${PN}/${PN}_${PV}.tar.gz > + https://cran.r-project.org/src/contrib/${PN//_/.}_${PV}.tar.gz > + https://cran.r-project.org/src/contrib/Archive/${PN//_/.}/${PN//_/.}_${PV}.tar.gz > " > -HOMEPAGE="https://cran.r-project.org/package=${PN}" > +HOMEPAGE="https://cran.r-project.org/package=${PN//_/.}" > > SLOT="0" > > -- > 2.35.1 > >