From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 83447158220 for ; Sun, 24 Nov 2024 22:47:38 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 01DFEE09CC for ; Sun, 24 Nov 2024 22:47:34 +0000 (UTC) Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1878EE0E6A for ; Thu, 7 Jul 2022 07:17:35 +0000 (UTC) Received: by mail-lf1-x12a.google.com with SMTP id z25so12052193lfr.2 for ; Thu, 07 Jul 2022 00:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oP6pBoyX11KZUb7YBfvo4ihC7cFLOsNb01oazLoi49U=; b=fQNVUer2E3oAfEcvDIKCisvT7ZRwmw4OiW93F3qmihq6HH600hMac9VpG4pCZ/C2G2 72rWHQUoysaZA+gPLt4Kas/ha7F+bBw66PZx70/JCw6fw5waY31F98w+w4JcDCF6OB3V cD9jtAP57SXGv1ILwsfy4+5UL8miHGExzHbb7yggzffnudPA5gwBKrsmmn2+Vw2vqJhY tTcbRd0hyEJy/egDJWE7/7XHW5HSGRgoPa5WD+zqVsDStFIoJ3XK96PZREl3UYxLYZbC dP7QKclp4/tA2ov+x6n/G3pVefeCuHRfHepCce9NLhrg//VU30FfSlqM01SNkh+0PA1l L6qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oP6pBoyX11KZUb7YBfvo4ihC7cFLOsNb01oazLoi49U=; b=7ac09KJJRodwemQnGKxWJ7Thtss1Qf5MxCCEoDcAX7z5PgtH8NCyCwbzBDpYoKB0Ye q9S5rKOlnvS+hmV3PetSw8yAT+/W+5hsFh6ObLm2/WRHIlIOP6SKaC502YI5Cu40hFjp BQByNblgIBrHo1+zpGBhtYaeSA2p7pvVjRHWVDxPZ6ieb7BdmKCL2edCPpE4D7s/bpcx l2YdFCFo2sbqljiP8DnT8cG/4Au4cSjQKGTP6i0ESalKaYUV9HyapI/fcb3FZ1lcXF4O hpdpOIajze0w/xcQBZqTA0I5c9TZkf6Fryz8hdCQkRA1/hXGGugoeok5GBUaD6gntOTx U2pw== X-Gm-Message-State: AJIora8mq3VVD7/7bRqVQ2Yo+NmdBfkWYmvUo92CsvN5Nj12uDGqKHZQ v+yLPGr+2vSiTIydkP2NflMtRTV5OOPwSfh0iOoOF411 X-Google-Smtp-Source: AGRyM1ufAORp9z1yTeWT4f736cVHFXjZPHtxrSaOK6dgC3Ysqu7keLjcio7yRs63DnsPihDLkTXsPiZ4JHei7vKvoH4= X-Received: by 2002:a05:6512:793:b0:47f:82d0:fadb with SMTP id x19-20020a056512079300b0047f82d0fadbmr28528711lfr.545.1657178253711; Thu, 07 Jul 2022 00:17:33 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Discussion on the GURU project and repository X-BeenThere: gentoo-guru@gentoo.org X-BeenThere: gentoo-guru@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20220705071539.2463760-1-me@r0bert.dev> <010b0181cd37837d-a86d4255-afbb-42bc-9ad8-7ac41a661b43-000000@eu-west-2.amazonses.com> In-Reply-To: From: Alessandro Barbieri Date: Thu, 7 Jul 2022 09:17:21 +0200 Message-ID: Subject: Re: [gentoo-guru] [RFC PATCH 1/3] eclass/R-packages: Use src/contrib or src/contrib/Archive from main CRAN To: =?UTF-8?B?QW5uYSDigJxDeWJlclRhaWxvcuKAnQ==?= Cc: gentoo-guru@lists.gentoo.org Content-Type: multipart/alternative; boundary="00000000000024600b05e331e1e4" X-Archives-Salt: d9ce2e1a-321c-44c2-aff7-cd1b44f2d374 X-Archives-Hash: a16f5184b0bed57680f13c2046e9c1a0 --00000000000024600b05e331e1e4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Il giorno mar 5 lug 2022 alle ore 09:58 Anna =E2=80=9CCyberTailor=E2=80=9D = ha scritto: > On 2022-07-05 07:16, Robert Greener wrote: > > The current SRC_URI searches all the CRAN mirrors for > > /src/contrib/${PN}_${PV}.tar.gz. This is problematic. Once a package is > updated > > on CRAN, the package is removed from this path and moved to > > /src/contrib/Archive/${PN}/${PN}_${PV}.tar.gz. The effect of this is > > that once a package goes out-of-date on CRAN, the ebuild will no longer > > build. This significantly increases the maintenance burden of dev-R/* > > packages, as it requires that they be up-to-date at all times. > > > > The proposal here, is to use just the main CRAN, so that every mirror > > doesn't have to be searched, to search the main repo, and then the > > archive. (also, some CRAN mirrors seem misconfigured and return a html > > document if the package is not found at > > /src/contrib/${PN}_${PV}.tar.gz). This means that if the package is > > out-of-date it will still build. > > > > Signed-off-by: Robert Greener > > --- > > eclass/R-packages.eclass | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/eclass/R-packages.eclass b/eclass/R-packages.eclass > > index aed8cce84..dd6b69933 100644 > > --- a/eclass/R-packages.eclass > > +++ b/eclass/R-packages.eclass > > @@ -21,7 +21,10 @@ esac > > > > EXPORT_FUNCTIONS src_unpack src_prepare src_configure src_compile > src_install pkg_postinst > > > > -SRC_URI=3D"mirror://cran/src/contrib/${PN}_${PV}.tar.gz" > > +SRC_URI=3D" > > + https://cran.r-project.org/src/contrib/${PN}_${PV}.tar.gz > > + > https://cran.r-project.org/src/contrib/Archive/${PN}/${PN}_${PV}.tar.gz > > +" > > Multiple SRC_URI doesn't work as fallback. You need a custom src_fetch > function instead. > > I like this idea, any downsides? --00000000000024600b05e331e1e4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Il giorno mar 5 lug 2022 alle ore 09:58 A= nna =E2=80=9CCyberTailor=E2=80=9D <cyb= er@sysrq.in> ha scritto:
On 2022-07-05 07:16, Robert Gree= ner wrote:
> The current SRC_URI searches all the CRAN mirrors for
> /src/contrib/${PN}_${PV}.tar.gz. This is problematic. Once a package i= s updated
> on CRAN, the package is removed from this path and moved to
> /src/contrib/Archive/${PN}/${PN}_${PV}.tar.gz. The effect of this is > that once a package goes out-of-date on CRAN, the ebuild will no longe= r
> build. This significantly increases the maintenance burden of dev-R/*<= br> > packages, as it requires that they be up-to-date at all times.
>
> The proposal here, is to use just the main CRAN, so that every mirror<= br> > doesn't have to be searched, to search the main repo, and then the=
> archive. (also, some CRAN mirrors seem misconfigured and return a html=
> document if the package is not found at
> /src/contrib/${PN}_${PV}.tar.gz). This means that if the package is > out-of-date it will still build.
>
> Signed-off-by: Robert Greener <me@r0bert.dev>
> ---
>=C2=A0 eclass/R-packages.eclass | 5 ++++-
>=C2=A0 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/eclass/R-packages.eclass b/eclass/R-packages.eclass
> index aed8cce84..dd6b69933 100644
> --- a/eclass/R-packages.eclass
> +++ b/eclass/R-packages.eclass
> @@ -21,7 +21,10 @@ esac
>=C2=A0
>=C2=A0 EXPORT_FUNCTIONS src_unpack src_prepare src_configure src_compil= e src_install pkg_postinst
>=C2=A0
> -SRC_URI=3D"mirror://cran/src/contrib/${PN}_${PV}.tar.gz" > +SRC_URI=3D"
> +=C2=A0 =C2=A0 =C2=A0https://c= ran.r-project.org/src/contrib/${PN}_${PV}.tar.gz
> +=C2=A0 =C2=A0 =C2=A0https://cran.r-project.org/src/contrib/Archive/${PN}/${PN}_${PV}.t= ar.gz
> +"

Multiple SRC_URI doesn't work as fallback. You need a custom src_fetch<= br> function instead.


I like this idea, any downsides?
<= /div>
--00000000000024600b05e331e1e4--