From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 3AE361581FB for ; Sun, 24 Nov 2024 22:47:38 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C4E29E09B5 for ; Sun, 24 Nov 2024 22:47:33 +0000 (UTC) Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A7A91E0F67 for ; Wed, 6 Jul 2022 00:25:10 +0000 (UTC) Received: by mail-lf1-x12e.google.com with SMTP id t24so23306644lfr.4 for ; Tue, 05 Jul 2022 17:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7nHPmMm05KvgTrw+WNGyq0s7dME+RH9NzUJTxsFYG3A=; b=fghwaZbnT0xYBZ4z2mUhfAbwQqIz90xk9M/DY7ppqR5skCX1uHVmLuKM1BHxxcOn3c agyH7yiggVKEe70pVIQWRb7c3naiipc1DPK1HglBvkKfrphSC+LwiZ/tdeA3lXjN/0th lMYqMEQDiLdxSUu4s7t0tCNV9eNakGkx9kawVKxkSU7JO4kCldymL7FEuu/rQUlCbORs 4Durd/pZFsB5Ig59v9tV9h6B3qJLy6mkucpHByO59lsQGBADnvU/eRzualghgqvnnnX3 39tgmvWQ443RwoEdb92sqYQcO7ua7NEMV5g0MkateBIfxKn9h4zG5ZW4uCVUEZGlJud9 5jQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7nHPmMm05KvgTrw+WNGyq0s7dME+RH9NzUJTxsFYG3A=; b=bV4IAs7poBIP9exzD5cHvCLFeTtUjY0LC/bOzi+kLOISdnUHwNDa9ojDcPPaHi0KrV qO/1wbyTJkf7U18lfgUvcNupV8gGcWlZZO7/KhfSnwqHACM6jME8uk4nF5AtJjBdlI6F XBfakDvp/M4jvfGe/g/CsqQiH3czAsRJj9mdfWCCZtSCarWiQvYNVx/+o4MxTqVtv38C LvRr59Pb+K8xM+p21Lbu77xKIuPLmjUHEYngBfsum/hRlRSb6KEaoPdxM9YnmDJMcsOu RRy4rKV/esu4qRNxbqzKJQzRAUySkGijTqS+wFS+/XJm4y418HXBVX4P35n7cJkTpUVt +owQ== X-Gm-Message-State: AJIora+JExaNwvhdPw6YJDM9vzYRHnsCvlSV69/VDpuMMQFvW4zxQIiZ QgpmS5MzeCGJEgBlaCNKwH+4jq0oC3RIPWZSZ0Y= X-Google-Smtp-Source: AGRyM1u8KeMShepJRgV4KFkhdzhEZB4XaEG/KTVajKBSQDa1ew8o/cxPQtIBY3fbmi55jBUBl9bSfUjYaBlTgZuqVK4= X-Received: by 2002:ac2:48b5:0:b0:482:a0bb:7602 with SMTP id u21-20020ac248b5000000b00482a0bb7602mr13306745lfg.61.1657067109075; Tue, 05 Jul 2022 17:25:09 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Discussion on the GURU project and repository X-BeenThere: gentoo-guru@gentoo.org X-BeenThere: gentoo-guru@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <010b0181cd374297-547f5cd8-3342-4193-970c-422efcd8fa0b-000000@eu-west-2.amazonses.com> In-Reply-To: <010b0181cd374297-547f5cd8-3342-4193-970c-422efcd8fa0b-000000@eu-west-2.amazonses.com> From: Alessandro Barbieri Date: Wed, 6 Jul 2022 02:24:56 +0200 Message-ID: Subject: Re: [gentoo-guru] [RFC PATCH 0/3] eclass/R-packages: improvements To: Robert Greener Cc: gentoo-guru@lists.gentoo.org Content-Type: multipart/alternative; boundary="00000000000067d0da05e3180004" X-Archives-Salt: 4822395a-1e47-4fe9-bdbb-25b7da974206 X-Archives-Hash: 8b4493fa6ff01fb8ccff1ccbd599360b --00000000000067d0da05e3180004 Content-Type: text/plain; charset="UTF-8" Il giorno mar 5 lug 2022 alle ore 09:16 Robert Greener ha scritto: > Hello, > > This is very much a RFC on some improvements to the R-packages eclass. > > There is currently a problem with the SRC_URI in that it will only work > with up-to-date packages, for example dplyr 1.0.9 will work, however, > dplyr 1.0.8 will not. This significantly increases the maintenance > burden of dev-R/*, as all packages must be up-to-date at all times, in > order for them to build. > > To fix this, I propose to change SRC_URI to use either src/contrib or > src/contrib/Archive (where old packages will be). However, the drawback > of this is that we only use the main CRAN. As there are many mirrors to > search, it would be impractial to search them all before searching the > archive. > > I also suggest 2 further changes. Firstly, replacing _ with . in the PN > in SRC_URI and HOMEPAGE. This is already done elsewhere in the eclass, > and would mean that these don't need to be overrided in the ebuild. > > Finally, I suggest adding a variable CRAN_PV, that defaults to PV, for > the case where the version is something like "1.2-24". This is used in > SRC_URI, meaning that this doesn't need to be overrided in the ebuild. > > -- > Robert > > Robert Greener (3): > eclass/R-packages: Use src/contrib or src/contrib/Archive from main > CRAN > eclass/R-packages: substitute _ with . in SRC_URI and HOMEPAGE > eclass/R-packages: Add CRAN_PV > > eclass/R-packages.eclass | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > > -- > 2.35.1 > > > I think all the changes are fine. The devmanual say: There are two valid cases for using thirdpartymirrors: 1. providing multiple download locations for mirror- or fetch-restricted packages, 2. dealing with upstreams that distribute their distfiles via a network of mirrors without a primary download location or a bouncer service. In any other case, the primary location must be used instead. The distfiles will be mirrored onto Gentoo infrastructure ; in that case, the benefit to using third-party mirror list does not outweigh the burden of maintaining it. So I think in this case we can drop the mirror list and go with the hack of listing both live and archive --00000000000067d0da05e3180004 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Il giorno mar 5 lug 2022 alle ore 09:16 R= obert Greener <me@r0bert.dev> ha= scritto:
Hello,

This is very much a RFC on some improvements to the R-packages eclass.

There is currently a problem with the SRC_URI in that it will only work
with up-to-date packages, for example dplyr 1.0.9 will work, however,
dplyr 1.0.8 will not. This significantly increases the maintenance
burden of dev-R/*, as all packages must be up-to-date at all times, in
order for them to build.

To fix this, I propose to change SRC_URI to use either src/contrib or
src/contrib/Archive (where old packages will be). However, the drawback
of this is that we only use the main CRAN. As there are many mirrors to
search, it would be impractial to search them all before searching the
archive.

I also suggest 2 further changes. Firstly, replacing _ with . in the PN
in SRC_URI and HOMEPAGE. This is already done elsewhere in the eclass,
and would mean that these don't need to be overrided in the ebuild.

Finally, I suggest adding a variable CRAN_PV, that defaults to PV, for
the case where the version is something like "1.2-24". This is us= ed in
SRC_URI, meaning that this doesn't need to be overrided in the ebuild.<= br>
--
Robert

Robert Greener (3):
=C2=A0 eclass/R-packages: Use src/contrib or src/contrib/Archive from main<= br> =C2=A0 =C2=A0 CRAN
=C2=A0 eclass/R-packages: substitute _ with . in SRC_URI=C2=A0 and HOMEPAGE=
=C2=A0 eclass/R-packages: Add CRAN_PV

=C2=A0eclass/R-packages.eclass | 8 ++++++--
=C2=A01 file changed, 6 insertions(+), 2 deletions(-)


--
2.35.1



=C2=A0I think all the changes are fine= .

The devmanual say:

There are two valid cases for using thirdpartymirrors:

  1. providing multiple download locations for mirror- or fetch-restricted packages,
  2. dealing with upstreams that distribute their distfiles via a network of mirrors without a primary download location or a bouncer service.

In any other case, the primary location must be used instead. The distfiles will be mirrored onto Gentoo infrastructure; in that case, the benefit to using third-party mirror list does not outweigh the burden of maintaining it.


So I = think in this case we can drop the mirror list and go with the hack of list= ing both live and archive

--00000000000067d0da05e3180004--