From: Ulrich Mueller <ulm@gentoo.org>
To: Andrew Savchenko <bircoph@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v2] fortran-2.eclass: support EAPI 7
Date: Fri, 02 Nov 2018 11:27:29 +0100 [thread overview]
Message-ID: <w6gy3ab3hbi.fsf@kph.uni-mainz.de> (raw)
In-Reply-To: <20181102012520.bcf256d577c0493a55570dac@gentoo.org> (Andrew Savchenko's message of "Fri, 2 Nov 2018 01:25:20 +0300")
[-- Attachment #1: Type: text/plain, Size: 609 bytes --]
>>>>> On Thu, 01 Nov 2018, Andrew Savchenko wrote:
> -inherit eutils toolchain-funcs
> +inherit toolchain-funcs
> +case ${EAPI:-0} in
> + # not used in the eclass, but left for backward compatibility with legacy users
> + 4|5|6) inherit eutils ;;
> + 7) ;;
> + *) die "EAPI=${EAPI} is not supported" ;;
> +esac
>
> case ${EAPI:-0} in
> - 4|5|6) EXPORT_FUNCTIONS pkg_setup ;;
> + 4|5|6|7) EXPORT_FUNCTIONS pkg_setup ;;
> *) die "EAPI=${EAPI} is not supported" ;;
> esac
Why is the second case statement needed? Program flow can only reach it
if the EAPI is 4, 5, 6, or 7.
Ulrich
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-11-02 10:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 22:38 [gentoo-dev] [PATCH] fortran-2.eclass: support EAPI 7 Andrew Savchenko
2018-10-28 18:29 ` Michał Górny
2018-10-29 0:57 ` Andrew Savchenko
2018-10-30 7:18 ` Michał Górny
2018-11-01 22:27 ` Andrew Savchenko
2018-11-02 0:47 ` Michael Orlitzky
2018-11-02 14:20 ` Michał Górny
2018-11-05 15:37 ` Andrew Savchenko
2018-10-29 22:52 ` Andreas K. Huettel
2018-11-01 22:26 ` Andrew Savchenko
2018-11-01 22:25 ` [gentoo-dev] [PATCH v2] " Andrew Savchenko
2018-11-02 10:27 ` Ulrich Mueller [this message]
2018-11-05 14:30 ` Andrew Savchenko
2018-11-05 15:37 ` [gentoo-dev] [PATCH v3 2/2] " Andrew Savchenko
2018-11-17 11:38 ` Andrew Savchenko
2018-11-05 15:38 ` [gentoo-dev] [PATCH v3 1/2] " Andrew Savchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w6gy3ab3hbi.fsf@kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=bircoph@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox