From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-86533-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 6F422138334
	for <garchives@archives.gentoo.org>; Mon,  7 Jan 2019 07:27:41 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 34C6AE0AEA;
	Mon,  7 Jan 2019 07:27:36 +0000 (UTC)
Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id D2EB5E0AE3
	for <gentoo-dev@lists.gentoo.org>; Mon,  7 Jan 2019 07:27:35 +0000 (UTC)
Received: from a1i15 (host2092.kph.uni-mainz.de [134.93.134.92])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: ulm)
	by smtp.gentoo.org (Postfix) with ESMTPSA id B947F335CF8;
	Mon,  7 Jan 2019 07:27:33 +0000 (UTC)
From: Ulrich Mueller <ulm@gentoo.org>
To: Georgy Yakovlev <gyakovlev@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/2] cargo.eclass: allow passing additional arguments to cargo
References: <20190107040122.6874-1-gyakovlev@gentoo.org>
Date: Mon, 07 Jan 2019 08:27:25 +0100
In-Reply-To: <20190107040122.6874-1-gyakovlev@gentoo.org> (Georgy Yakovlev's
	message of "Sun, 6 Jan 2019 20:01:21 -0800")
Message-ID: <w6gtvil0vxe.fsf@kph.uni-mainz.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
X-Archives-Salt: 18d4391e-f5d2-4b0d-9d56-48d9e8919056
X-Archives-Hash: d9087b0bc38aa334786ef9a1d036b947

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

>>>>> On Mon, 07 Jan 2019, Georgy Yakovlev wrote:

>  cargo_src_compile() {
>  	debug-print-function ${FUNCNAME} "$@"
>=20=20
>  	export CARGO_HOME=3D"${ECARGO_HOME}"
>=20=20
> -	cargo build -j $(makeopts_jobs) $(usex debug "" --release) \
> +	cargo build -j $(makeopts_jobs) $(usex debug "" --release) "${@}" \

Keep constistent style, "$@" is without braces just above.

>  cargo_src_install() {
>  	debug-print-function ${FUNCNAME} "$@"
>=20
> -	cargo install -j $(makeopts_jobs) --root=3D"${D}/usr" $(usex debug --de=
bug "") \
> +	cargo install -j $(makeopts_jobs) --root=3D"${D}/usr" $(usex debug --de=
bug "") "${@}" \

Ditto.

Ulrich

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEZlHkP3TnuTbxrN0HwwkGhRxhwnMFAlwy/10ACgkQwwkGhRxh
wnNIigf/cmGiXf0JZZTwUP/rw+PjqiQTmQ/JcMz/6WbnrBbUq0uQj5sWC5gk61ph
Tu+l3gSHnwtGW8jmggYBqvI4A2eKll7poON/BFf5PqK1jVX6BCZVGRSE0lvUO5WH
7WD1xySvKTxBomk9UjFyW+UoAnYMq40B7zZxX4y/i6rBa+pCYKNeNDp0a0bgFtHR
u+Zi+i30COOSWV754xVCG2w581FXDUSvHTfUzov1zqFXgT7uRFjhZBtxgETeyGpL
2UjgajaD+E/r9U5EKnPToY32yutD7YdSptKPQKnIKp2HVn8z8HM/CkcMnsvzdaIY
7OtCxywZBBJrqo6b54kzN8K/Mt0ztA==
=ODMO
-----END PGP SIGNATURE-----
--=-=-=--