From: Ulrich Mueller <ulm@gentoo.org>
To: Georgy Yakovlev <gyakovlev@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/2] cargo.eclass: allow passing additional arguments to cargo
Date: Mon, 07 Jan 2019 08:27:25 +0100 [thread overview]
Message-ID: <w6gtvil0vxe.fsf@kph.uni-mainz.de> (raw)
In-Reply-To: <20190107040122.6874-1-gyakovlev@gentoo.org> (Georgy Yakovlev's message of "Sun, 6 Jan 2019 20:01:21 -0800")
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
>>>>> On Mon, 07 Jan 2019, Georgy Yakovlev wrote:
> cargo_src_compile() {
> debug-print-function ${FUNCNAME} "$@"
>
> export CARGO_HOME="${ECARGO_HOME}"
>
> - cargo build -j $(makeopts_jobs) $(usex debug "" --release) \
> + cargo build -j $(makeopts_jobs) $(usex debug "" --release) "${@}" \
Keep constistent style, "$@" is without braces just above.
> cargo_src_install() {
> debug-print-function ${FUNCNAME} "$@"
>
> - cargo install -j $(makeopts_jobs) --root="${D}/usr" $(usex debug --debug "") \
> + cargo install -j $(makeopts_jobs) --root="${D}/usr" $(usex debug --debug "") "${@}" \
Ditto.
Ulrich
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-01-07 7:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 4:01 [gentoo-dev] [PATCH 1/2] cargo.eclass: allow passing additional arguments to cargo Georgy Yakovlev
2019-01-07 4:01 ` [gentoo-dev] [PATCH 2/2] cargo.eclass: add standard src_test Georgy Yakovlev
2019-01-07 7:27 ` Ulrich Mueller [this message]
2019-01-07 20:33 ` [gentoo-dev] [PATCH 1/2] cargo.eclass: allow passing additional arguments to cargo Georgy Yakovlev
2019-01-07 20:33 ` [gentoo-dev] [PATCH 2/2] cargo.eclass: add standard src_test Georgy Yakovlev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w6gtvil0vxe.fsf@kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=gyakovlev@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox