From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 83447138334 for ; Wed, 11 Dec 2019 06:08:23 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 76C02E082D; Wed, 11 Dec 2019 06:08:19 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 09077E0821 for ; Wed, 11 Dec 2019 06:08:18 +0000 (UTC) Received: from a1i15 (a1i15.kph.uni-mainz.de [134.93.134.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ulm) by smtp.gentoo.org (Postfix) with ESMTPSA id 92D6934D91B for ; Wed, 11 Dec 2019 06:08:17 +0000 (UTC) From: Ulrich Mueller To: Subject: Re: [gentoo-dev] [PATCH v4] mount-boot.eclass: Check if /boot is sane, but don't try to mount it. References: Date: Wed, 11 Dec 2019 07:08:04 +0100 In-Reply-To: ("Ulrich \=\?utf-8\?Q\?M\=C3\=BC\?\= \=\?utf-8\?Q\?ller\=22's\?\= message of "Sat, 07 Dec 2019 10:10:14 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: bf3a69b1-5c49-4cca-9c7c-4b5e97c024b5 X-Archives-Hash: b1c4001bb17ac5f3a78486e51784032f --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> On Sat, 07 Dec 2019, Ulrich M=C3=BCller wrote: > The eclass failed to remount a read-only mounted /boot, because package > collision sanity checks in recent Portage versions prevented it from > reaching pkg_preinst() at all. Furthermore, with the "mount-sandbox" > feature enabled, the mount won't be propagated past pkg_preinst() and > installed files would end up under the (shadowed) mount point. > Therefore don't even attempt to mount /boot ourselves, but error out > if it isn't mounted read/write and ask the user to mount /boot. > Also clean up and simplify. (For example, awk is a grown-up program > which doesn't need any help from egrep or sed. :-) > Closes: https://bugs.gentoo.org/532264 > See-also: https://bugs.gentoo.org/274130#c5 > Signed-off-by: Ulrich M=C3=BCller > --- > v3: Exit awk commands on first match. > v4: Added die statements after awk commands > Fixed typo in mount-boot_is_disabled function documentation > Reverted renaming of I_KNOW_WHAT_I_AM_DOING variable Pushed (with one small spelling change in an error message). Ulrich --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEZlHkP3TnuTbxrN0HwwkGhRxhwnMFAl3wh8cACgkQwwkGhRxh wnPT8ggAtaTvBRpvlxXDGwcPoepQv1fR3bNKlPPNQg0tp/j2X1CC4B3h8yjcP82z TC5TKaeTzKkX3+ahbg+csXaHCQvYAYwxAHwxGiDSOK8H9tYNop7taaBMFpca7Ua6 o7dWNx9AyKpFigRnla2RAyb7SfrehkY9aXXOxbseOAD+HmMl9LJHuZ7xJko9ZrHs EiJT/ZJ/edBpgsozRBrhMJTQhmsKFa4KAIeykYTaGknCpR2kGVSwIGxDMQRwumkT ZK6Uw28yFgZXlRoShmK9ezmLMfZWhC6jNElQcRwgWI7enM+p11DfflE3DKcGMh7S UAcJ8ei0hU8zIF5KdtJmRfoGPSnZ1A== =B7GU -----END PGP SIGNATURE----- --=-=-=--