From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D2F7E138334 for ; Sun, 20 Oct 2019 17:45:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 70814E0C2F; Sun, 20 Oct 2019 17:45:48 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0ECECE0C15 for ; Sun, 20 Oct 2019 17:45:48 +0000 (UTC) Received: from a1i15 (host2092.kph.uni-mainz.de [134.93.134.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ulm) by smtp.gentoo.org (Postfix) with ESMTPSA id B2B2734C0A3; Sun, 20 Oct 2019 17:45:46 +0000 (UTC) From: Ulrich Mueller To: David Seifert Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] font.eclass: Ban EAPIs < 5 References: <20191020165012.3498212-1-soap@gentoo.org> Date: Sun, 20 Oct 2019 19:45:36 +0200 In-Reply-To: <20191020165012.3498212-1-soap@gentoo.org> (David Seifert's message of "Sun, 20 Oct 2019 18:50:12 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: f185f27f-fab7-4bf8-af16-1ea493da9143 X-Archives-Hash: 4a8a3778f3ae81f526347415595a1ef4 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >>>>> On Sun, 20 Oct 2019, David Seifert wrote: > - if [[ -e fonts.alias ]]; then > - doins fonts.alias || die "failed to install fonts.alias" # TODO old E= API cleanup > - fi > + [[ -e fonts.alias ]] && doins fonts.alias > fi > } Is the function's return value of any importance? The function will now return shell false if fonts.alias doesn't exist, while previously it returned true. > - [[ -n ${DOCS} ]] && { dodoc ${DOCS} || die "docs installation failed" ;= } # TODO old EAPI cleanup > + einstalldocs =20 > # install common docs > - for commondoc in COPYRIGHT README{,.md,.txt} NEWS AUTHORS BUGS ChangeLo= g FONTLOG.txt; do > + for commondoc in COPYRIGHT FONTLOG.txt; do > [[ -s ${commondoc} ]] && dodoc ${commondoc} > done This changes the set of installed files, if the DOCS variable is defined. Is that intentional? > - if [[ -e "${EROOT%/}"/etc/fonts/conf.avail/${conffile##*/} ]]; then > - elog " ${conffile##*/}" > - fi > + [[ -e "${EROOT%/}"/etc/fonts/conf.avail/${conffile##*/} ]] && elog " = ${conffile##*/}" This doesn't change any functionality, but it adds an overlong line for no good reason. Ulrich --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEZlHkP3TnuTbxrN0HwwkGhRxhwnMFAl2snUAACgkQwwkGhRxh wnOIUwgAz/ypSY2oelesHztMsfeZSK33aV57RTzQI4h0ACdJUw00cYyi6g7QktJu FrERasTIh0XpL+dyzfKtL8uPSxxlvBDW5e57LdKKKbnUjMx56AoSsRIq2nEmyZk5 q06fskJgZAf5Hm37by83jQKVQHxfy/bwetbCHiQ1ziRfrsdImFuEOz/foJUg5spL QD0NQG4J4L600kwplNkyaqc3zAx2KLb+Uap9npQkY1iR8LCIUZMMfhrgwaGKBAoU eL6eKoCpyTL1TLD94CUS72RMOojrUvB4o8r36GvtQqQb64q5bXKrAq+Dvv2KP6yL 9MmkpUyRwrarXD3cXvj5TxxtGjWRsw== =pEz/ -----END PGP SIGNATURE----- --=-=-=--