From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C064D138334 for ; Sat, 7 Dec 2019 05:44:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 33427E08FC; Sat, 7 Dec 2019 05:44:33 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D6782E08E8 for ; Sat, 7 Dec 2019 05:44:32 +0000 (UTC) Received: from a1i15 (a1i15.kph.uni-mainz.de [134.93.134.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ulm) by smtp.gentoo.org (Postfix) with ESMTPSA id 0498F34D26E; Sat, 7 Dec 2019 05:44:30 +0000 (UTC) From: Ulrich Mueller To: Sergei Trofimovich Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH v3] mount-boot.eclass: Check if /boot is sane, but don't try to mount it. In-Reply-To: <20191206235333.3addea86@sf> (Sergei Trofimovich's message of "Fri, 6 Dec 2019 23:53:33 +0000") References: <20191206235333.3addea86@sf> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Sat, 07 Dec 2019 06:44:21 +0100 Message-ID: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: 2c2b9efb-1cbe-4b6d-97bf-99abde720ac0 X-Archives-Hash: 741ccfc2341d65fe170f5a0e79d9f827 --=-=-= Content-Type: text/plain >>>>> On Sat, 07 Dec 2019, Sergei Trofimovich wrote: >> # The user wants us to leave things be. >> - if [[ -n ${DONT_MOUNT_BOOT} ]] ; then >> + if [[ -n ${I_KNOW_WHAT_I_AM_DOING} ]] ; then >> return 0 >> fi > The rest of patch looks ok but I find I_KNOW_WHAT_I_AM_DOING > proliferation worrying. Having enough eclasses guard things on it I > don't really know what I am doing :) > For example developer profile sets it on by default and disables perl > error checks. I don't think it's intentional. Oh, I forgot that it is set globally in the developer profile (and I think that's a stupid idea). Indeed we should use a different variable then. > I suggest giving this variable a unique specific name. Would it be acceptable to leave DONT_MOUNT_BOOT in place? It would have the advantage that users won't have to update their config. > And phase out ${I_KNOW_WHAT_I_AM_DOING} uses from tree completely. That's a separate discussion. Ulrich --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEZlHkP3TnuTbxrN0HwwkGhRxhwnMFAl3rPDUACgkQwwkGhRxh wnNz+Af/fnOMF00x25YI94EIhh6C/76Y9zt49ZFwuTwpY+H2ZD6w9Fmp7k0goOPz 4T7AtYo68iLbd3AfwvXn73faAJiSORd56xPZ9e2ifVAzMzrzrTZ8y5j+5PV76E8U IRegdaaMtNbqHb0rpj2R1pj+OIB9vg0zBJwJ7vryBt2/ivRQ9NDqM/k7/vohlWqF uUDAjq/yqDyi7CK/RRRocm8QF5W3/TVmlQUCR9wiV3FnTU1SaNpYixAcJ8+AOgxD 68gVEOcPgHUlgzBiiouek/DPCz8xVSdy2k+GEvH5M2CyO58gMCRc/dszNbfIaZuk WnUKf4SDJDjiUQPjYlCgxYsYyBY7Sg== =NMzH -----END PGP SIGNATURE----- --=-=-=--