Re: [gentoo-dev] [PATCH v3] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

[Ulrich Mueller <ulm@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

>>>>> On Sat, 07 Dec 2019, Sergei Trofimovich wrote:

>>  	# The user wants us to leave things be.
>> -	if [[ -n ${DONT_MOUNT_BOOT} ]] ; then
>> +	if [[ -n ${I_KNOW_WHAT_I_AM_DOING} ]] ; then
>>  		return 0
>>  	fi

> The rest of patch looks ok but I find I_KNOW_WHAT_I_AM_DOING
> proliferation worrying. Having enough eclasses guard things on it I
> don't really know what I am doing :)

> For example developer profile sets it on by default and disables perl
> error checks. I don't think it's intentional.

Oh, I forgot that it is set globally in the developer profile (and I
think that's a stupid idea). Indeed we should use a different variable
then.

> I suggest giving this variable a unique specific name.

Would it be acceptable to leave DONT_MOUNT_BOOT in place? It would have
the advantage that users won't have to update their config.

> And phase out ${I_KNOW_WHAT_I_AM_DOING} uses from tree completely.

That's a separate discussion.

Ulrich

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]