public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Ulrich Müller" <ulm@gentoo.org>
To: <gentoo-dev@lists.gentoo.org>
Subject: [gentoo-dev] [PATCH v2 3/3] elisp.eclass: Depend on app-editors/emacs directly.
Date: Fri, 20 Dec 2019 14:44:04 +0100	[thread overview]
Message-ID: <w6glfr7nmcb.fsf@kph.uni-mainz.de> (raw)
In-Reply-To: <cover.1576663643.git.ulm@gentoo.org> ("Ulrich \=\?utf-8\?Q\?M\?\= \=\?utf-8\?Q\?\=C3\=BCller\=22's\?\= message of "Wed, 18 Dec 2019 12:08:16 +0100")

[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]

This replaces the indirect dependency on virtual/emacs.

Update pkg_setup() to call elisp-check-emacs-version instead of the
now deprecated elisp-need-emacs.

Signed-off-by: Ulrich Müller <ulm@gentoo.org>
---
 eclass/elisp.eclass | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/eclass/elisp.eclass b/eclass/elisp.eclass
index df160ea01e2..2b50111a535 100644
--- a/eclass/elisp.eclass
+++ b/eclass/elisp.eclass
@@ -30,8 +30,8 @@
 # @DEFAULT_UNSET
 # @DESCRIPTION:
 # If you need anything different from Emacs 23, use the NEED_EMACS
-# variable before inheriting elisp.eclass.  Set it to the major version
-# your package uses and the dependency will be adjusted.
+# variable before inheriting elisp.eclass.  Set it to the version your
+# package uses and the dependency will be adjusted.
 
 # @ECLASS-VARIABLE: ELISP_PATCHES
 # @DEFAULT_UNSET
@@ -70,7 +70,7 @@ esac
 EXPORT_FUNCTIONS src_{unpack,prepare,configure,compile,install} \
 	pkg_{setup,postinst,postrm}
 
-RDEPEND=">=virtual/emacs-${NEED_EMACS:-23}"
+RDEPEND=">=app-editors/emacs-${NEED_EMACS}:*"
 case ${EAPI} in
 	4|5|6) DEPEND="${RDEPEND}" ;;
 	*) BDEPEND="${RDEPEND}" ;;
@@ -78,16 +78,11 @@ esac
 
 # @FUNCTION: elisp_pkg_setup
 # @DESCRIPTION:
-# Test if the eselected Emacs version is sufficient to fulfil the major
+# Test if the eselected Emacs version is sufficient to fulfil the
 # version requirement of the NEED_EMACS variable.
 
 elisp_pkg_setup() {
-	elisp-need-emacs "${NEED_EMACS:-23}"
-	case $? in
-		0) ;;
-		1) die "Emacs version too low" ;;
-		*) die "Could not determine Emacs version" ;;
-	esac
+	elisp-check-emacs-version
 }
 
 # @FUNCTION: elisp_src_unpack
-- 
2.24.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  parent reply	other threads:[~2019-12-20 13:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 11:08 [gentoo-dev] [PATCH 0/3] elisp{,-common}.eclass update for emacs-vcs consolidation Ulrich Müller
2019-12-18 11:08 ` [gentoo-dev] [PATCH 1/3] elisp-common.eclass: Allow full versions in elisp-need-emacs() Ulrich Müller
2019-12-18 11:08 ` [gentoo-dev] [PATCH 2/3] elisp-common.eclass: Update documentation Ulrich Müller
2019-12-18 11:08 ` [gentoo-dev] [PATCH 3/3] elisp.eclass: Depend on app-editors/emacs directly Ulrich Müller
2019-12-18 11:47 ` [gentoo-dev] [PATCH 0/3] elisp{,-common}.eclass update for emacs-vcs consolidation Michał Górny
2019-12-18 12:01   ` Ulrich Mueller
2019-12-18 12:19 ` Michael Orlitzky
2019-12-18 16:34   ` Ulrich Mueller
2019-12-18 23:28     ` Michael Orlitzky
2019-12-20  1:19       ` Michael Orlitzky
2019-12-21  6:57         ` Ulrich Mueller
2019-12-21 11:27           ` Michael Orlitzky
2019-12-21 11:39             ` Ulrich Mueller
2019-12-21 11:41               ` Michael Orlitzky
2019-12-21 11:50                 ` Ulrich Mueller
2019-12-21 11:49               ` Michael Orlitzky
2019-12-21 11:52                 ` Ulrich Mueller
2019-12-21 13:31                   ` Michael 'veremitz' Everitt
2019-12-20 13:43 ` [gentoo-dev] [PATCH v2 1/3] elisp-common.eclass: New function elisp-check-emacs-version Ulrich Müller
2019-12-20 13:43 ` [gentoo-dev] [PATCH v2 2/3] elisp-common.eclass: Update documentation Ulrich Müller
2019-12-20 13:44 ` Ulrich Müller [this message]
2019-12-20 22:10   ` [gentoo-dev] [PATCH v2 3/3] elisp.eclass: Depend on app-editors/emacs directly Ulrich Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=w6glfr7nmcb.fsf@kph.uni-mainz.de \
    --to=ulm@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox