From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7F048138334 for ; Sun, 20 Oct 2019 18:57:31 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9098DE0C64; Sun, 20 Oct 2019 18:57:27 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 45993E0C56 for ; Sun, 20 Oct 2019 18:57:27 +0000 (UTC) Received: from a1i15 (host2092.kph.uni-mainz.de [134.93.134.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ulm) by smtp.gentoo.org (Postfix) with ESMTPSA id 8AD1534C0B7; Sun, 20 Oct 2019 18:57:25 +0000 (UTC) From: Ulrich Mueller To: David Seifert Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] font.eclass: Ban EAPIs < 5 References: <20191020165012.3498212-1-soap@gentoo.org> Date: Sun, 20 Oct 2019 20:57:16 +0200 In-Reply-To: (David Seifert's message of "Sun, 20 Oct 2019 19:51:21 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: 830a2587-abae-41df-91e3-711e1f96606b X-Archives-Hash: a45489ce12f353d74e83233f046eb51f --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >>>>> On Sun, 20 Oct 2019, David Seifert wrote: >> > - [[ -n ${DOCS} ]] && { dodoc ${DOCS} || die "docs installation >> > failed" ; } # TODO old EAPI cleanup >> > + einstalldocs >> >=20 >> > # install common docs >> > - for commondoc in COPYRIGHT README{,.md,.txt} NEWS AUTHORS BUGS >> > ChangeLog FONTLOG.txt; do >> > + for commondoc in COPYRIGHT FONTLOG.txt; do >> > [[ -s ${commondoc} ]] && dodoc ${commondoc} >> > done >> This changes the set of installed files, if the DOCS variable is >> defined. Is that intentional? > You mean if it's *not* defined? No, if it *is* defined. For example, if an ebuild defines DOCS but doesn't include README.txt in the list, then that file was previously being installed, but isn't any longer with the eclass change. >> This doesn't change any functionality, but it adds an overlong line >> for no good reason. > The idea was to avoid if statements if you can use the more succinct > form. Then at least wrap the long line. Still, I doubt that it will improve readability, as compared to the original if statement. Ulrich --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEZlHkP3TnuTbxrN0HwwkGhRxhwnMFAl2srgwACgkQwwkGhRxh wnPNDAgAo88E3UJQ0587Lyt3Cgf8CERK0ZICQ+gU+fSrbdBk0JO/QLgmbj52sv5d 2fG0j51wWriU+z3aR/gdSNBB/y5IvKT2GAukTRNzm66ovFY8w9N5An4Gx8nMBbqL scthLmTr1a98WbABJPLa/9aALbB2vKH2H212K1RnszbImFMpEeSz46gtACC9yRHV TE7gAHYUKNfNStD3c2Ur7P4CUxDnJq9rNiPne5KXcq2wMs0hLV7PmCEgYaCF0Dc5 RcOsI0Vu5JjCKHUiKEjgmlPe7KkcsmXqi6OV9RaQNfAwvfj2XLQOkD+n+0NwITQ7 PttqVq8hTaQe1PU2Do3rK2u7G2ng7g== =SI5O -----END PGP SIGNATURE----- --=-=-=--