From: Ulrich Mueller <ulm@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 5/5] xdg.eclass: support EAPI 7
Date: Mon, 01 Oct 2018 08:10:19 +0200 [thread overview]
Message-ID: <w6ga7ny42pg.fsf@kph.uni-mainz.de> (raw)
In-Reply-To: <20180930225035.25434-5-floppym@gentoo.org> (Mike Gilbert's message of "Sun, 30 Sep 2018 18:50:35 -0400")
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
>>>>> On Mon, 01 Oct 2018, Mike Gilbert wrote:
> @@ -15,7 +15,7 @@
> inherit xdg-utils
> case "${EAPI:-0}" in
This was there before your change, but the ":-0" isn't needed here ...
> - 4|5|6)
> + 4|5|6|7)
> EXPORT_FUNCTIONS src_prepare pkg_preinst pkg_postinst pkg_postrm
> ;;
> *) die "EAPI=${EAPI} is not supported" ;;
... while this line could profit from it.
> @@ -35,7 +35,7 @@ fi
> xdg_src_prepare() {
> xdg_environment_reset
>
> - has ${EAPI:-0} 6 && default
> + has "${EAPI:-0}" 4 5 || default
Ditto.
Ulrich
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2018-10-01 6:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-30 22:50 [gentoo-dev] [PATCH 1/5] xdg-utils.eclass: avoid duplicate leading slashes Mike Gilbert
2018-09-30 22:50 ` [gentoo-dev] [PATCH 2/5] xdg-utils.eclass: support EAPI 7 Mike Gilbert
2018-09-30 22:50 ` [gentoo-dev] [PATCH 3/5] xdg.eclass: move deps to RDEPEND Mike Gilbert
2018-10-01 5:40 ` [gentoo-dev] " Rémi Cardona
2018-10-01 12:27 ` Gilles Dartiguelongue
2018-10-01 13:00 ` Mike Gilbert
2018-10-01 13:17 ` James Le Cuirot
2018-10-01 14:08 ` Mike Gilbert
2018-10-02 2:14 ` Marty E. Plummer
2018-10-03 2:22 ` Mike Gilbert
2018-10-03 7:12 ` Andreas Sturmlechner
2018-10-03 13:23 ` Mike Gilbert
2018-09-30 22:50 ` [gentoo-dev] [PATCH 4/5] xdg.eclass: look for files in ED and cleanup array syntax Mike Gilbert
2018-09-30 22:50 ` [gentoo-dev] [PATCH 5/5] xdg.eclass: support EAPI 7 Mike Gilbert
2018-10-01 6:10 ` Ulrich Mueller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w6ga7ny42pg.fsf@kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox