From: Ulrich Mueller <ulm@gentoo.org>
To: William Hubbs <williamh@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/3] lua-single.eclass: clean up the eapi test
Date: Fri, 02 Jul 2021 19:46:22 +0200 [thread overview]
Message-ID: <uwnq84nip@gentoo.org> (raw)
In-Reply-To: <20210702173632.15603-2-williamh@gentoo.org> (William Hubbs's message of "Fri, 2 Jul 2021 12:36:30 -0500")
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
>>>>> On Fri, 02 Jul 2021, William Hubbs wrote:
> case ${EAPI:-0} in
This could be just ${EAPI}.
> - 0|1|2|3|4|5|6)
> - die "Unsupported EAPI=${EAPI} (too old) for ${ECLASS}"
> - ;;
> 7|8)
> ;;
> *)
> - die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
> + die "Unsupported EAPI=${EAPI} for ${ECLASS}"
> ;;
May I suggest that we standardise the error message? Many eclasses have
this (see for example toolchain-funcs.eclass):
*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
> esac
Same for the other two eclasses.
Ulrich
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
next prev parent reply other threads:[~2021-07-02 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 17:36 [gentoo-dev] [PATCH 0/3] clean up lua eclass eapi checks William Hubbs
2021-07-02 17:36 ` [gentoo-dev] [PATCH 1/3] lua-single.eclass: clean up the eapi test William Hubbs
2021-07-02 17:46 ` Ulrich Mueller [this message]
2021-07-02 17:36 ` [gentoo-dev] [PATCH 2/3] lua-utils.eclass: " William Hubbs
2021-07-02 17:36 ` [gentoo-dev] [PATCH 3/3] lua.eclass: " William Hubbs
-- strict thread matches above, loose matches on Subject: below --
2021-07-05 21:12 [gentoo-dev] [PATCH 0/3] lua eclass cleanup round 2 William Hubbs
2021-07-05 21:12 ` [gentoo-dev] [PATCH 1/3] lua-single.eclass: clean up the eapi test William Hubbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uwnq84nip@gentoo.org \
--to=ulm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=williamh@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox