From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 3844A15806E for ; Fri, 26 May 2023 08:44:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A8438E0845; Fri, 26 May 2023 08:44:54 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 65A2DE0821 for ; Fri, 26 May 2023 08:44:54 +0000 (UTC) From: Ulrich Mueller To: "Volkmar W. Pogatzki" Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] java-pkg-simple.eclass: respect SLOT="0" in JAVA_LAUNCHER_FILENAME In-Reply-To: <20230526081646.7272-1-gentoo@pogatzki.net> (Volkmar W. Pogatzki's message of "Fri, 26 May 2023 10:16:46 +0200") References: <20230526081646.7272-1-gentoo@pogatzki.net> Date: Fri, 26 May 2023 10:44:45 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: 9d22196c-ab0b-45c2-9b04-e78ac54522e0 X-Archives-Hash: 68a1fe962d080b11c7c4919fefc4768e --=-=-= Content-Type: text/plain >>>>> On Fri, 26 May 2023, Volkmar W Pogatzki wrote: > -: "${JAVA_LAUNCHER_FILENAME:=${PN}-${SLOT}}" > +if [[ ${SLOT} = 0 ]]; then > + JAVA_LAUNCHER_FILENAME="${PN}" > +else > + JAVA_LAUNCHER_FILENAME="${PN}-${SLOT}" > +fi This will no longer allow overriding the variable in the ebuild (at least not pre-inherit). Is this intentional? Ulrich --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmRwcX0PHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uvicH/jdldH3ntSvAzp3odWcBr8iPw1oOCoOXoCh+ bBlHoWQKw5dgHdX4d7VN3+9tQbuU0Z7eagPZUMAnvh81hjDcqYX9TzSAtYzbZRY5 ia0vBubfVDijvO8BnQU4WbCyQPYjb8iW8aK2DY2Mmeff/OujXez7W0TcEMWnGx4T 2F9rr3X4w5fBjPce9fq12KKDfcYAe16i1MteuVArhlwVOKwwSd336HV2g1hQX88m 7kiWO+xSXJSeVVp12k+IClFgr45ARDrgks4YlhsGK8sGwoXLxTg9obo28Z03goq4 mj03hUEnyQaQqG4Kpu6eA60+8E2GOoPljJ9g/dKQuqu3UFoQ0Tk= =LL5Z -----END PGP SIGNATURE----- --=-=-=--