From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-99968-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 06D9F158009
	for <garchives@archives.gentoo.org>; Mon, 26 Jun 2023 11:14:48 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id EEA63E08F3;
	Mon, 26 Jun 2023 11:14:43 +0000 (UTC)
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 89F0FE08CA
	for <gentoo-dev@lists.gentoo.org>; Mon, 26 Jun 2023 11:14:43 +0000 (UTC)
From: Ulrich Mueller <ulm@gentoo.org>
To: Jaco Kroon <jaco@uls.co.za>
Cc: gentoo-dev@lists.gentoo.org,  Sam James <sam@gentoo.org>,
  base-system@gentoo.org,  kde@gentoo.org
Subject: Re: [gentoo-dev] [PATCH] cmake.eclass: workaround S=${WORKDIR}
 creating builddir above ${WORKDIR}
In-Reply-To: <5ba4d13b-6f67-a37e-117c-1ffeac736042@uls.co.za> (Jaco Kroon's
	message of "Mon, 26 Jun 2023 12:45:56 +0200")
References: <20230626095716.1292297-1-sam@gentoo.org> <u1qhypl2g@gentoo.org>
	<5ba4d13b-6f67-a37e-117c-1ffeac736042@uls.co.za>
Date: Mon, 26 Jun 2023 13:14:37 +0200
Message-ID: <uwmzqo4pu@gentoo.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: 31842bb5-232c-4144-870d-99fb1d709ddc
X-Archives-Hash: c0cd09b130a4ad97832b3089b49c1bdd

>>>>> On Mon, 26 Jun 2023, Jaco Kroon wrote:

>> if [[ ${BUILD_DIR} !=3D "${WORKDIR}"/* ]]; then

> BUILD_DIR=3D"${WORKDIR}/../build"

Oh right, I hadn't thought about the case that the ebuild would override
it. (AFAICS cmake.eclass itself doesn't do .. in BUILD_DIR.)

> I know it's pathological ... but still.=C2=A0 readlink -f should be
> considered here unless it can be guaranteed that BUILD_DIR will not
> contain .. components at this stage.