From: Ulrich Mueller <ulm@gentoo.org>
To: Mike Gilbert <floppym@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org, Matt Turner <mattst88@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH v2] meson.eclass: allow disabling verbose compilation
Date: Thu, 20 Jul 2023 18:58:04 +0200 [thread overview]
Message-ID: <uwmyujzab@gentoo.org> (raw)
In-Reply-To: <CAJ0EP42ZhnEXhhjg4eri6Er9Ytsjc7-vO20PqrdWeFSJB63=wA@mail.gmail.com> (Mike Gilbert's message of "Thu, 20 Jul 2023 11:45:37 -0400")
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
>>>>> On Thu, 20 Jul 2023, Mike Gilbert wrote:
> On Thu, Jul 20, 2023 at 11:06 AM Florian Schmaus <flow@gentoo.org> wrote:
>> While the bash language has no boolean datatype, you can exploit the
>> fact that 'true' and 'false' are usually shell builtins:
>>
>> : "${MESON_VERBOSE:=true}"
>>
>> and then later
>>
>> if $MESON_VERBOSE; then
>> mesoncompileargs+=( --verbose )
>> fi
> I think we generally try to avoid exploiting that behavior in ebuilds.
> It's usually much more obvious to check for a non-empty string, or for
> a specific value.
Testing for a non-empty variable is also faster than executing "true"
or "false" builtins from variable values. (Which doesn't play any role
here, but readability of the code does.)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
next prev parent reply other threads:[~2023-07-20 16:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 14:51 [gentoo-dev] [PATCH] meson.eclass: allow disabling verbose compilation Matt Turner
2023-07-17 14:56 ` Adrian Schollmeyer
2023-07-17 15:24 ` Matt Turner
2023-07-17 15:23 ` [gentoo-dev] " Matt Turner
2023-07-18 16:44 ` [gentoo-dev] [PATCH v2] " Matt Turner
2023-07-19 7:23 ` Florian Schmaus
2023-07-20 15:00 ` Matt Turner
2023-07-20 15:06 ` Florian Schmaus
2023-07-20 15:08 ` Matt Turner
2023-07-20 15:45 ` Mike Gilbert
2023-07-20 16:58 ` Ulrich Mueller [this message]
2023-07-20 17:11 ` Ionen Wolkens
2023-07-20 17:33 ` Ionen Wolkens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uwmyujzab@gentoo.org \
--to=ulm@gentoo.org \
--cc=floppym@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=mattst88@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox