From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 98C5F1384DD for ; Thu, 24 Jun 2021 23:29:42 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 84DAFE0905; Thu, 24 Jun 2021 23:29:39 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D1AE7E08ED for ; Thu, 24 Jun 2021 23:29:38 +0000 (UTC) From: Ulrich Mueller To: Conrad Kostecki Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 2/2] eclass/myspell-r2.eclass: add EAPI 8 support In-Reply-To: <20210624202619.20178-2-conikost@gentoo.org> (Conrad Kostecki's message of "Thu, 24 Jun 2021 22:26:19 +0200") References: <20210624202619.20178-1-conikost@gentoo.org> <20210624202619.20178-2-conikost@gentoo.org> Date: Fri, 25 Jun 2021 01:29:19 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: ab50cf33-bc57-4fe2-8128-d3efd6e5a7dc X-Archives-Hash: ccd987e87d901b40c74dae9b639eb80e --=-=-= Content-Type: text/plain >>>>> On Thu, 24 Jun 2021, Conrad Kostecki wrote: > -if [[ ${EAPI:-0} == 7 ]]; then > +if [[ ${EAPI:-0} -ge 7 ]]; then EAPI is a string, not a number. I'd suggest using a string comparison, e.g.: if [[ ${EAPI} != [56] ]]; then (Negative logic, so there won't be any need to update it again for the next EAPI.) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmDVFVAPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4u38gH/RhOyARtb5k+5abjKeZdrnSi32aRyhBKmEFX CkLC7h4kNZiSZAmBGTHIHhL54OiNXC5oX5lyNzFvmOzz5kMGsXTDJ4ghgsurdIGp rUtmDvDik6a8JL4tZ02QzgpBlzn+99Hqth29etxfARINsnFWHeFtMw6fieuzHwdQ mx7hK133DROJt7IDN2z7Y7pj0QwOxfn5mUwgls49nNnfm09Pbkl6R0SrqXYq1HbJ r9WTh2zA4SgD/WMxn40o3PMSMSXyrIVbFWDFwrl0DcS0ouqiC7ruO10qppvIW/e4 wD2CQV8oVk9zybu3yZXt6nglsYmOdbhy46qNg4jqV/jf9cuFCPg= =UD65 -----END PGP SIGNATURE----- --=-=-=--