From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id F3DAE15800A for ; Wed, 12 Jul 2023 17:42:45 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9738CE07F6; Wed, 12 Jul 2023 17:42:41 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 597C5E0794 for ; Wed, 12 Jul 2023 17:42:41 +0000 (UTC) From: Ulrich Mueller To: =?utf-8?B?TWljaGHFgiBHw7Nybnk=?= Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 4/4] distutils-r1.eclass: Disable LTO when using cargo.eclass In-Reply-To: <20230712122503.309626-5-mgorny@gentoo.org> (=?utf-8?Q?=22Mic?= =?utf-8?Q?ha=C5=82_G=C3=B3rny=22's?= message of "Wed, 12 Jul 2023 14:22:55 +0200") References: <20230712122503.309626-1-mgorny@gentoo.org> <20230712122503.309626-5-mgorny@gentoo.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Date: Wed, 12 Jul 2023 19:42:32 +0200 Message-ID: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: 7b4fd8a6-bd69-4b82-a34c-8ccc83cddbb9 X-Archives-Hash: bf2919f1385073cc627fe2160c9c9d2d --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> On Wed, 12 Jul 2023, Micha=C5=82 G=C3=B3rny wrote: > + if [[ ${_CARGO_ECLASS} ]]; then > + filter-lto > + fi Testing for an internal variable of another eclass seems less than ideal. How about "has cargo ${INHERITED}" instead? Ulrich --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmSu5ggPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uyVwH/22OMBIx6N76gZfvv+CrJTpUBWvxInA/p+YW qac6gPeMB7ErXwZBK0A/SmVWxDRqOQY5HpNROlzB/Wl9HM5YMmSlYqQ6I38WjUyA XkTZEZ4TrKzorUHYNwDW3HxkgqLv0Ka2X0az1dNjJ/hb80gnF8R1xjVZ0zAUeBjh AaKSSjrmtJxrBnQLGWDCDuaMfRlSeZcxYupaLyQkotPSs7Lqe97tm43w5Z2QfhN1 DdIJmU+7RGGKjEm4gwYQaoJXXB4MbO2iefysxqTd/Hwvggi4sPkk+C6RGiRtbQe3 oB0rjw/aM5MqQ1NKXmB2q7viXLF7l0OBEkg7D1HtH5JD0gt7lzE= =81A+ -----END PGP SIGNATURE----- --=-=-=--