From: Ulrich Mueller <ulm@gentoo.org>
To: "Michał Górny" <mgorny@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 4/4] distutils-r1.eclass: Disable LTO when using cargo.eclass
Date: Wed, 12 Jul 2023 19:42:32 +0200 [thread overview]
Message-ID: <uttu958mv@gentoo.org> (raw)
In-Reply-To: <20230712122503.309626-5-mgorny@gentoo.org> ("Michał Górny"'s message of "Wed, 12 Jul 2023 14:22:55 +0200")
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
>>>>> On Wed, 12 Jul 2023, Michał Górny wrote:
> + if [[ ${_CARGO_ECLASS} ]]; then
> + filter-lto
> + fi
Testing for an internal variable of another eclass seems less than
ideal. How about "has cargo ${INHERITED}" instead?
Ulrich
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
next prev parent reply other threads:[~2023-07-12 17:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 12:22 [gentoo-dev] [PATCH 0/4] python eclasses: PyPy3.10 update + cargo LTO strip-flags Michał Górny
2023-07-12 12:22 ` [gentoo-dev] [PATCH 1/4] python-utils-r1.eclass: Require >=dev-python/pypy3-7.3.12 Michał Górny
2023-07-12 12:22 ` [gentoo-dev] [PATCH 2/4] python-utils-r1.eclass: pypy3 is now 3.10-only Michał Górny
2023-07-12 12:22 ` [gentoo-dev] [PATCH 3/4] distutils-r1.eclass: Update addpredict for PyPy3.10 Michał Górny
2023-07-12 12:22 ` [gentoo-dev] [PATCH 4/4] distutils-r1.eclass: Disable LTO when using cargo.eclass Michał Górny
2023-07-12 17:42 ` Ulrich Mueller [this message]
2023-07-12 17:48 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uttu958mv@gentoo.org \
--to=ulm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox