From: Ulrich Mueller <ulm@gentoo.org>
To: Eli Schwartz <eschwartz93@gmail.com>
Cc: gentoo-dev@lists.gentoo.org, "Michał Górny" <mgorny@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: epytest, use NO_COLOR rather than NOCOLOR
Date: Mon, 11 Dec 2023 21:38:14 +0100 [thread overview]
Message-ID: <uttooqxu1@gentoo.org> (raw)
In-Reply-To: <24d59a88-071d-49ce-9376-9a3193b27693@gmail.com> (Eli Schwartz's message of "Mon, 11 Dec 2023 15:21:29 -0500")
[-- Attachment #1: Type: text/plain, Size: 639 bytes --]
>>>>> On Mon, 11 Dec 2023, Eli Schwartz wrote:
>> "Command-line software which adds ANSI color to its output by default
>> should check for a NO_COLOR environment variable that, when present
>> and not an empty string (regardless of its value), prevents the
>> addition of ANSI color." -- https://no-color.org/
> Again, not according to pytest itself. ;)
> Given the commit message says:
> """
> Adjust it to correctly check whether it is set at all rather than to a
> specific value, to match the behavior of pytest itself.
> """
The standard is defined by sno-color.org. If pytest does something
different then it is a bug.
Ulrich
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
next prev parent reply other threads:[~2023-12-11 20:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 12:44 [gentoo-dev] [PATCH] python-utils-r1.eclass: epytest, use NO_COLOR rather than NOCOLOR Michał Górny
2023-12-11 18:57 ` Eli Schwartz
2023-12-11 19:27 ` Michał Górny
2023-12-11 20:22 ` Eli Schwartz
2023-12-11 19:30 ` Ulrich Mueller
2023-12-11 20:21 ` Eli Schwartz
2023-12-11 20:38 ` Ulrich Mueller [this message]
2023-12-11 21:11 ` Toralf Förster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uttooqxu1@gentoo.org \
--to=ulm@gentoo.org \
--cc=eschwartz93@gmail.com \
--cc=gentoo-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox