From: Ulrich Mueller <ulm@gentoo.org>
To: Florian Schmaus <flow@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v5] greadme.eclass: new eclass
Date: Tue, 23 Jul 2024 12:55:55 +0200 [thread overview]
Message-ID: <uttgg4bt0@gentoo.org> (raw)
In-Reply-To: <06bee5df-0362-4112-b61e-419df181a562@gentoo.org> (Florian Schmaus's message of "Tue, 23 Jul 2024 10:15:27 +0200")
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
>>>>> On Tue, 23 Jul 2024, Florian Schmaus wrote:
>> Having more than one element in REPLACING_VERSIONS is certainly a
>> corner case, but I still wonder about the logic. Shouldn't it be
>> the other way around, i.e. if there is _any_ empty ${_GREADME_SHOW}
>> then there is an identical file installed that has been shown
>> before, i.e. the file should _not_ be shown again?
> I would argue the other way around: if there is a non-identical file
> installed, then it should be shown.
> But as you said, it's a corner case. I wouldn't worry about it until
> we hit it and gained experience what the best behavior in this
> situation is. Then we can change the code accordingly.
WFM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
prev parent reply other threads:[~2024-07-23 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 9:25 [gentoo-dev] [PATCH v5] greadme.eclass: new eclass Florian Schmaus
2024-07-21 8:26 ` Ulrich Mueller
2024-07-23 8:15 ` Florian Schmaus
2024-07-23 10:55 ` Ulrich Mueller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uttgg4bt0@gentoo.org \
--to=ulm@gentoo.org \
--cc=flow@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox