From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D112B15817D for ; Tue, 4 Jun 2024 17:45:53 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1CCEEE2B4D; Tue, 4 Jun 2024 17:45:50 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 95C92E2B48 for ; Tue, 4 Jun 2024 17:45:49 +0000 (UTC) From: Ulrich Mueller To: Florian Schmaus Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install) In-Reply-To: <90350087-100f-4ca1-a9a5-b714d82b2d9a@gentoo.org> (Florian Schmaus's message of "Tue, 4 Jun 2024 17:15:12 +0200") References: <20240109083914.242561-1-flow@gentoo.org> <20240602135716.66992-1-flow@gentoo.org> <20240602135716.66992-2-flow@gentoo.org> <90350087-100f-4ca1-a9a5-b714d82b2d9a@gentoo.org> Date: Tue, 04 Jun 2024 19:45:39 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: aed47b67-b895-4c04-92d0-9f07d6e89f37 X-Archives-Hash: 03210e0f5eb702c6ac70ac864766ee12 --=-=-= Content-Type: text/plain >>>>> On Tue, 04 Jun 2024, Florian Schmaus wrote: > Both is fine with me. > That said, many filesystem support inline data. If I am not mistaken, > then its even enabled by default for xfs (which we recommend in the > handbook) and btrfs. Also some README.gentoo files become suitable for > inlining after compression (btrfs' limit is 2048 bytes). I see 48 README.gentoo* files on my system here, and the _uncompressed_ size of the largest of them (belonging to www-client/firefox) is 1238 bytes. So, by your metric all of them could be inlined even without compressing them. 14 of the 48 files aren't even compressed because their size is below Portage's size limit (which is 128 bytes IIRC). Also, it's not surprising that these files are very small. If they were large, they wouldn't be suitable as output in pkg_postinst. OTOH, if the filesystem is ext4, README.gentoo and the hash file will each use up one 4 KiB block and one inode. > Considering this, the 4-byte hash file is superior under the right > circumstances when compared to excluding README.gentoo from > compression. And I could imagine that the circumstances are right for > many of our users. I very much doubt this. In any case, the above size considerations aren't important. My main point is that the code is getting way too complicated for the simple task of printing a few lines in pkg_postinst. Ulrich --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmZfUsMPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uTB8IALpC6ihQoqW6Ty0nneBaxEa3OT9lpL4OvrJ/ O4qtqXGsUwqnjSMHAA8bdJlhaHxTsV8SbN6TQljZ5Wypq0I6qM/J1ZLQo84mofG6 YngQVNdynD5i5qWFUJuoOIhAiXKJqGY3RzNJk40G2OP6PFk3Sb6k4QpworLv+AGq AWeiPdR8F5ndojGSMB81hcngRuioyB+HI/O1IpaFvssEoaSk+c/MEVCi9ZntJHau 0ts6GYrriqA5xZG/cco5+EQm9/oa9kmUcq28RuWCjBSYYIFaF1PanxByZT90Ksxx bok824ggRlfO2vSXpB3FwCGDyeMm2VOtyaafipZgAgASPjeSPsg= =FZM4 -----END PGP SIGNATURE----- --=-=-=--