From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-101114-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 38DA215815E
	for <garchives@archives.gentoo.org>; Sat,  3 Feb 2024 16:51:59 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 76DA1E2B36;
	Sat,  3 Feb 2024 16:51:55 +0000 (UTC)
Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 31543E2B33
	for <gentoo-dev@lists.gentoo.org>; Sat,  3 Feb 2024 16:51:55 +0000 (UTC)
From: Ulrich Mueller <ulm@gentoo.org>
To: Maciej =?utf-8?Q?Bar=C4=87?= <xgqt@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org,  dotnet@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/7] eclass/dotnet-pkg-base.eclass: quotes
 and style tweaks for edge cases
In-Reply-To: <20240203162422.91906-1-xgqt@gentoo.org> ("Maciej =?utf-8?Q?B?=
 =?utf-8?Q?ar=C4=87=22's?= message
	of "Sat, 3 Feb 2024 17:24:12 +0100")
References: <20240203162422.91906-1-xgqt@gentoo.org>
Date: Sat, 03 Feb 2024 17:51:49 +0100
Message-ID: <uo7cxwkwq@gentoo.org>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: 87887dfb-88ab-4c38-915d-7ad087b145c3
X-Archives-Hash: 9e7261c5d238bf312b1097f30b9135df

>>>>> On Sat, 03 Feb 2024, Maciej Bar=C4=87 wrote:

> -if [[ ${CATEGORY}/${PN} !=3D dev-dotnet/dotnet-runtime-nugets ]] ; then
> +if [[ "${CATEGORY}/${PN}" !=3D dev-dotnet/dotnet-runtime-nugets ]] ; then

These quotes are not necessary.

> -	if [[ ${CATEGORY}/${PN} !=3D dev-dotnet/csharp-gentoodotnetinfo ]] ; th=
en
> -		DOTNET_PKG_BDEPS+=3D" dev-dotnet/csharp-gentoodotnetinfo "
> +	if [[ "${CATEGORY}/${PN}" !=3D dev-dotnet/csharp-gentoodotnetinfo ]] ; =
then

Same.

> +		DOTNET_PKG_BDEPS+=3D"
> +			dev-dotnet/csharp-gentoodotnetinfo
> +		"