public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: Florian Schmaus <flow@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org,  tex@gentoo.org
Subject: Re: [gentoo-dev] [PATCH v2] texlive-module.eclass: install man pages in right location
Date: Wed, 01 May 2024 11:07:53 +0200	[thread overview]
Message-ID: <uo79plx1y@gentoo.org> (raw)
In-Reply-To: <20240501084411.46961-1-flow@gentoo.org> (Florian Schmaus's message of "Wed, 1 May 2024 10:44:11 +0200")

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

>>>>> On Wed, 01 May 2024, Florian Schmaus wrote:

> +			local grep_expressions=()

Declare f as local, too.

> +			# Transform texlive_core_man_pages into grep expressions
> +			# that will be used to filter out any man page that is
> +			# already installed by app-text/texlive-core.
> +			for f in "${texlive_core_man_pages[@]}"; do
> +				# Ensure that all dots are escaped so that they are
> +				# matched lilterarily. Also wrap the file in '/' and '$'

"literarily"

> +				# within the expression.
> +				grep_expressions+=(-e "/${f//./\\.}$")

Hm, bash seems to be o.k. with this final lone dollar sign, but maybe it
would be cleaner to escape it as "\$".

> +			done

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

      reply	other threads:[~2024-05-01  9:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30  8:53 [gentoo-dev] [PATCH] texlive-module.eclass: install man pages in right location Florian Schmaus
2024-05-01  8:44 ` [gentoo-dev] [PATCH v2] " Florian Schmaus
2024-05-01  9:07   ` Ulrich Mueller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uo79plx1y@gentoo.org \
    --to=ulm@gentoo.org \
    --cc=flow@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=tex@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox