From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8F45E158094 for ; Mon, 8 Aug 2022 15:40:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C09EFE09C1; Mon, 8 Aug 2022 15:40:16 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 5BF7DE070D for ; Mon, 8 Aug 2022 15:40:16 +0000 (UTC) From: Ulrich Mueller To: Yiyang Wu Cc: gentoo-dev@lists.gentoo.org, Benda Xu Subject: Re: [gentoo-dev] [PATCH 1/2] rocm.eclass: new eclass In-Reply-To: (Yiyang Wu's message of "Mon, 8 Aug 2022 22:15:26 +0800") References: Date: Mon, 08 Aug 2022 17:40:05 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: d4aeb486-26e4-4f3b-ad89-046cd9d6723b X-Archives-Hash: 023622c62491e080de7a314a2a769d7e --=-=-= Content-Type: text/plain >>>>> On Mon, 08 Aug 2022, Yiyang Wu wrote: > +case ${EAPI} in > + 0|1|2|3|4|5|6) > + die "${ECLASS}: unsupported EAPI=${EAPI:-0} (too old)" > + ;; > + 7|8) > + ;; > + *) > + die "${ECLASS}: unsupported EAPI=${EAPI} (unknown)" > + ;; > +esac We no longer distinguished between too old and unknown. Modern style is like this: case ${EAPI} in 7|8) ;; *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;; esac --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmLxLlUPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4u8dEIAMwmzObnOf6HM88+8olhhvEHDErcgiu4oiyP 2OTLSwoX41NvevfyzAacIhR1oIzRoEaRotA4m4O89DbbCujbUxnCVmw2WY/u1sdH rY2O5/HBpdTsqgjS6xP6nrcWtfQhH3qsp8LWiOmUQuvCKuZJeKYJh7eVeIx/UaYD ucRvJeTs4Vjc9u+ttBl8vMm/A23TxVhYgasrHMFeNHez7GwTSK3S22oXeE6/yXmN MOFbyrEt+2K3QOywBzgFza4sJX0mHzq1X71v2YoE4KxlBGFJlpptDfiKMFu9Kf+B GW601aUN9Vh7LycJoToww+F+OqumnPZnXH3Y7cumFfSHIGTdEso= =h/CQ -----END PGP SIGNATURE----- --=-=-=--