public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: Florian Schmaus <flow@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org,
	 Paul Zander <negril.nx+gentoo@gmail.com>,
	tex@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/2] texlive-module.eclass: add texlive-module_update_tlpdb
Date: Tue, 02 Apr 2024 16:57:22 +0200	[thread overview]
Message-ID: <uil0z6cdp@gentoo.org> (raw)
In-Reply-To: <20240402140738.359511-2-flow@gentoo.org> (Florian Schmaus's message of "Tue, 2 Apr 2024 16:07:38 +0200")

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

>>>>> On Tue, 02 Apr 2024, Florian Schmaus wrote:

> +	# If we are updating this package, then there is no need to update
> +	# the tlpdb in postrm, as it will be again updated in postinst.
> +	[[ -n ${REPLACING_VERSIONS} && ${EBUILD_PHASE} == postrm ]] && return

Sorry for having missed this before. REPLACING_VERSIONS isn't defined
in pkg_postrm, so the test should be for REPLACED_BY_VERSION.

Also it would be cleaner to test for the phase first, to make sure that
the variable is valid in this phase:

	[[ ${EBUILD_PHASE} == postrm && -n ${REPLACED_BY_VERSION} ]] && return

Ulrich

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

      reply	other threads:[~2024-04-02 14:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 14:07 [gentoo-dev] [PATCH 1/2] texlive-module.eclass: only invoke etexmf-update in postinst if not replacing versions Florian Schmaus
2024-04-02 14:07 ` [gentoo-dev] [PATCH 2/2] texlive-module.eclass: add texlive-module_update_tlpdb Florian Schmaus
2024-04-02 14:57   ` Ulrich Mueller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uil0z6cdp@gentoo.org \
    --to=ulm@gentoo.org \
    --cc=flow@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=negril.nx+gentoo@gmail.com \
    --cc=tex@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox