From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id BA011158020 for ; Sun, 25 Dec 2022 22:15:05 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 47506E0877; Sun, 25 Dec 2022 22:15:02 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 050E3E07E1 for ; Sun, 25 Dec 2022 22:15:02 +0000 (UTC) From: Ulrich Mueller To: Sam James Cc: gentoo-dev@lists.gentoo.org, kernel@gentoo.org Subject: Re: [gentoo-dev] [PATCH 3/3] kernel-2.eclass: minor whitespace fixes In-Reply-To: <20221225191714.757003-3-sam@gentoo.org> (Sam James's message of "Sun, 25 Dec 2022 19:17:14 +0000") References: <20221225191714.757003-1-sam@gentoo.org> <20221225191714.757003-3-sam@gentoo.org> Date: Sun, 25 Dec 2022 23:14:49 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: 9c1f7340-c106-4172-9d63-fd58bf66503c X-Archives-Hash: 9d74e3d4dd72bc2b3159e27cf137cbc1 --=-=-= Content-Type: text/plain >>>>> On Sun, 25 Dec 2022, Sam James wrote: > - [[ $# -gt 3 ]] && die "Error in kernel-2_kernel_is(): too many parameters" > + [[ $# -gt 3 ]] && die "Error in ${ECLASS}_${FUNCNAME}(): too many parameters" This might be somewhat misleading. The name of the function is just ${FUNCNAME}, I suppose? (Also, "Error in" is redundant in a die message.) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmOoy1kPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uh1EIANMggFsVSqe46S7TG8SnIkkLu8vhOs4GdrYz JL+iOTVCh/nX2wPfRLr1xeLneIlQ1p8pTkgcFgwpaCP8CLVaep7ulznb/nEpZKCR FlnzY6d7nNpOBdYdWDTIH6iGx4C0jb/2Mk1x6N8AIymAGScwB48Bjq0Ff/CFU0/Q uG9xSL+Uf+uVq6XPKgH9b4ayFovKK3tjO2r6xqfCm1EgzYLe8K/G876a7R7481Ik y9zzv7JIvxt+Cvbl9PqK6le7JHXTLOkgpNnfUrAFGz5nNTwVSl1Km3Qb/OmU7lnG M38dnYTDoBqMvBv1NkYmiQwpwfyo/18poaCk9S72Zl5GidcCp2E= =sXUQ -----END PGP SIGNATURE----- --=-=-=--