From: Ulrich Mueller <ulm@gentoo.org>
To: Sam James <sam@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org, kernel@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 3/3] kernel-2.eclass: minor whitespace fixes
Date: Sun, 25 Dec 2022 23:14:49 +0100 [thread overview]
Message-ID: <uh6xjjfl2@gentoo.org> (raw)
In-Reply-To: <20221225191714.757003-3-sam@gentoo.org> (Sam James's message of "Sun, 25 Dec 2022 19:17:14 +0000")
[-- Attachment #1: Type: text/plain, Size: 349 bytes --]
>>>>> On Sun, 25 Dec 2022, Sam James wrote:
> - [[ $# -gt 3 ]] && die "Error in kernel-2_kernel_is(): too many parameters"
> + [[ $# -gt 3 ]] && die "Error in ${ECLASS}_${FUNCNAME}(): too many parameters"
This might be somewhat misleading. The name of the function is just
${FUNCNAME}, I suppose? (Also, "Error in" is redundant in a die
message.)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
next prev parent reply other threads:[~2022-12-25 22:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-25 19:17 [gentoo-dev] [PATCH 1/3] linux-mod.eclass: use consistent style Sam James
2022-12-25 19:17 ` [gentoo-dev] [PATCH 2/3] linux-info.eclass: " Sam James
2022-12-25 21:28 ` Sam James
2022-12-25 19:17 ` [gentoo-dev] [PATCH 3/3] kernel-2.eclass: minor whitespace fixes Sam James
2022-12-25 22:14 ` Ulrich Mueller [this message]
2022-12-25 22:19 ` [gentoo-dev] [PATCH 1/3] linux-mod.eclass: use consistent style Ulrich Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uh6xjjfl2@gentoo.org \
--to=ulm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=kernel@gentoo.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox