public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: Florian Schmaus <flow@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org,
	 Paul Zander <negril.nx+gentoo@gmail.com>,
	tex@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/2] texlive-{common,module}.eclass: update for TeX Live 2023
Date: Tue, 16 Jan 2024 11:35:53 +0100	[thread overview]
Message-ID: <uedehin06@gentoo.org> (raw)
In-Reply-To: <20240116092634.264336-3-flow@gentoo.org> (Florian Schmaus's message of "Tue, 16 Jan 2024 10:26:34 +0100")

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

>>>>> On Tue, 16 Jan 2024, Florian Schmaus wrote:

>  case ${EAPI} in
> -	7) inherit eapi8-dosym ;;
> +	7)
> +		inherit eapi8-dosym
> +		dosym(){ dosym8 "$@"; }

For good reason, eapi-dosym.eclass doesn't override package manager
commands, and the texlive eclasses shouldn't do that either.

Does it even work? dosym8 calls dosym, so wouldn't redefining dosym in
terms of dosym8 cause an endless loop?

So, either add an EAPI conditional where dosym8 is currently used (I see
only one place), or define dosym8 as an alias for dosym in EAPI 8.

> +		;;
> +	8) ;;
>  	*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
>  esac

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

      reply	other threads:[~2024-01-16 10:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-16  9:26 [gentoo-dev] [PATCH 0/2] texlive eclass updates, in preperation of TeX Live 2023 bump Florian Schmaus
2024-01-16  9:26 ` [gentoo-dev] [PATCH 1/2] profiles/thirdpartymirrors: add 'ctan' mirror Florian Schmaus
2024-01-16 15:16   ` Michael Orlitzky
2024-01-16  9:26 ` [gentoo-dev] [PATCH 2/2] texlive-{common,module}.eclass: update for TeX Live 2023 Florian Schmaus
2024-01-16 10:35   ` Ulrich Mueller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uedehin06@gentoo.org \
    --to=ulm@gentoo.org \
    --cc=flow@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=negril.nx+gentoo@gmail.com \
    --cc=tex@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox