From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id A9ECD15802E for ; Tue, 2 Jul 2024 07:38:47 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 55FBD2BC03D; Tue, 2 Jul 2024 07:38:43 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EE7492BC02F for ; Tue, 2 Jul 2024 07:38:42 +0000 (UTC) From: Ulrich Mueller To: gentoo-dev@lists.gentoo.org Cc: Ionen Wolkens Subject: Re: [gentoo-dev] [PATCH 1/2] linux-info.eclass: Drop temporary fix for powerpc In-Reply-To: (Ionen Wolkens's message of "Tue, 2 Jul 2024 01:35:04 -0400") References: <20240701213611.30911-1-ulm@gentoo.org> Date: Tue, 02 Jul 2024 09:38:33 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: fa771601-7af7-4b61-bf8d-bad83cdc039d X-Archives-Hash: dd0c58b45ad0b793f9de505e912498b4 --=-=-= Content-Type: text/plain >>>>> On Tue, 02 Jul 2024, Ionen Wolkens wrote: > On a side-note, it was further a no-op for linux-mod-r1 which opted to > intentionally ignore BUILD_FIXES (variable is currently read by kernel-2 > and linux-mod-r0) and nobody complained. > If wanted, technically all references of BUILD_FIXES could probably be > removed from eclasses given (normally) nothing sets that variable beside > that ppc workaround. It was also undocumented and more like a private > variable. > Albeit some ebuilds (like the pre-linux-mod-r1 lttng-modules ebuild) > and users have wrongly used it, so it could break some spacebar heating. > No real need to bother with linux-mod.eclass either way given it's due > for eventual removal. A follow-up patch removing the two remaining references to BUILD_FIXES (in getfilevar(), both in linux-info.eclass and in kernel-2.eclass) would be trivial. The variable was originally added by commit [1]. Any other opinions on this? Ulrich [1] https://gitweb.gentoo.org/archive/repo/gentoo-2.git/commit/?id=c3d67d556962a79e055053f7cb88c67c46df293f --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmaDrnkPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uPWkH/0SLrr+zcxeGAH+0WVLXn4zXGRTYV6dKCNDk lgsJKYo+u/fkdvFdFWfS/5dYH3AdtL4FuHlPnxqVbEc3/+nSNDLtTurdTvtplSZN npVms8BQsEVNn+C5DCJNyA9xfGbk38vwastG35I39s+f/caV3Mg/wZ+l0PLQKo0F 83mM+JVSGQeKOEOCpFmCBd7L+wKVCk6uDNT8l/XStdih6/ABM79cGCaAvtqpTg4T CM9+F6JvOKSA/AL/w907IEuFsGGZuhLREd1bh0mouWgJfeXG6Ojhe+SsANqzmh9B 4fvss8p9qOJKkDNevnQCZXPIce2OcQfxhevlIhcMiz6k6W/Afd8= =yEMy -----END PGP SIGNATURE----- --=-=-=--