Re: [gentoo-dev] [PATCH 1/2] linux-info.eclass: Drop temporary fix for powerpc

[Ulrich Mueller <ulm@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

>>>>> On Tue, 02 Jul 2024, Ionen Wolkens wrote:

> On a side-note, it was further a no-op for linux-mod-r1 which opted to
> intentionally ignore BUILD_FIXES (variable is currently read by kernel-2
> and linux-mod-r0) and nobody complained.

> If wanted, technically all references of BUILD_FIXES could probably be
> removed from eclasses given (normally) nothing sets that variable beside
> that ppc workaround. It was also undocumented and more like a private
> variable.

> Albeit some ebuilds (like the pre-linux-mod-r1 lttng-modules ebuild)
> and users have wrongly used it, so it could break some spacebar heating.
> No real need to bother with linux-mod.eclass either way given it's due
> for eventual removal.

A follow-up patch removing the two remaining references to BUILD_FIXES
(in getfilevar(), both in linux-info.eclass and in kernel-2.eclass)
would be trivial. The variable was originally added by commit [1].

Any other opinions on this?

Ulrich

[1] https://gitweb.gentoo.org/archive/repo/gentoo-2.git/commit/?id=c3d67d556962a79e055053f7cb88c67c46df293f

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]