From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-99744-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 222AC15806E
	for <garchives@archives.gentoo.org>; Mon, 29 May 2023 09:52:08 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 3E2EDE0849;
	Mon, 29 May 2023 09:52:04 +0000 (UTC)
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id CC883E0802
	for <gentoo-dev@lists.gentoo.org>; Mon, 29 May 2023 09:52:03 +0000 (UTC)
From: Ulrich Mueller <ulm@gentoo.org>
To: "Volkmar W. Pogatzki" <gentoo@pogatzki.net>
Cc: "gentoo-dev@lists.gentoo.org" <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] java-pkg-simple.eclass: respect SLOT="0"
 in JAVA_LAUNCHER_FILENAME
In-Reply-To: <1093286864.697740.1685344396997@email.ionos.de> (Volkmar W.
	Pogatzki's message of "Mon, 29 May 2023 09:13:16 +0200 (CEST)")
References: <20230526081646.7272-1-gentoo@pogatzki.net> <uwn0v4h36@gentoo.org>
	<1093286864.697740.1685344396997@email.ionos.de>
Date: Mon, 29 May 2023 11:51:57 +0200
Message-ID: <ua5xn1n42@gentoo.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
X-Archives-Salt: a1cb6e62-931a-4e68-ab09-25f3a3547646
X-Archives-Hash: 1b0e3ea155315dd955e23d18fc39fce0

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

>>>>> On Mon, 29 May 2023, Volkmar W Pogatzki wrote:

>> > -: "${JAVA_LAUNCHER_FILENAME:=3D${PN}-${SLOT}}"
>> > +if [[ ${SLOT} =3D 0 ]]; then
>> > +	JAVA_LAUNCHER_FILENAME=3D"${PN}"
>> > +else
>> > +	JAVA_LAUNCHER_FILENAME=3D"${PN}-${SLOT}"
>> > +fi
>>=20
>> This will no longer allow overriding the variable in the ebuild
>> (at least not pre-inherit). Is this intentional?

> It exactly does what it's supposed to do.
> No clue about "not pre-inherit".

With the above, JAVA_LAUNCHER_FILENAME=3D"foo" in the ebuild will work if
comes after the inherit line, but not if it is before it.

> How to sanitize?

As in your v2. :)

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmR0db0PHHVsbUBnZW50
b28ub3JnAAoJEFGIM1CIQV4uT6oH+QFEz7UKkMs6dgVeVAUwikdZXe0VRwSTbkXA
36WRX0i3OQ7RU7Xe1Owaa9bUFMAM2FkqTpBLiRYPjedQ3AsHrnUzmvAE+uvji2zF
yaYK53T0lQtg4Fd5/AGgSNeA9red3is7NeIB8WmOO+SrmSfN6H+aiP3XSVkF4Ql3
NyTn0KABx++CcrXUwHOLYbBbIPr2quGWTSXQ4NnZ3UibCBC11BGYf4G0Lm3oCvsP
hPGPNOiRJ4LBue7KrSboPgVCdZAm6uPjin/civyeQ1Sh2BOlvqx12GTVJzDIDgc2
1O8H3ReAmX7CEoyia6snao2MVRJbfQ5vbGnidfzisYV+4ZQ2BeM=
=yjqj
-----END PGP SIGNATURE-----
--=-=-=--