From: Ulrich Mueller <ulm@gentoo.org>
To: "Volkmar W. Pogatzki" <gentoo@pogatzki.net>
Cc: "gentoo-dev@lists.gentoo.org" <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] java-pkg-simple.eclass: respect SLOT="0" in JAVA_LAUNCHER_FILENAME
Date: Mon, 29 May 2023 11:51:57 +0200 [thread overview]
Message-ID: <ua5xn1n42@gentoo.org> (raw)
In-Reply-To: <1093286864.697740.1685344396997@email.ionos.de> (Volkmar W. Pogatzki's message of "Mon, 29 May 2023 09:13:16 +0200 (CEST)")
[-- Attachment #1: Type: text/plain, Size: 636 bytes --]
>>>>> On Mon, 29 May 2023, Volkmar W Pogatzki wrote:
>> > -: "${JAVA_LAUNCHER_FILENAME:=${PN}-${SLOT}}"
>> > +if [[ ${SLOT} = 0 ]]; then
>> > + JAVA_LAUNCHER_FILENAME="${PN}"
>> > +else
>> > + JAVA_LAUNCHER_FILENAME="${PN}-${SLOT}"
>> > +fi
>>
>> This will no longer allow overriding the variable in the ebuild
>> (at least not pre-inherit). Is this intentional?
> It exactly does what it's supposed to do.
> No clue about "not pre-inherit".
With the above, JAVA_LAUNCHER_FILENAME="foo" in the ebuild will work if
comes after the inherit line, but not if it is before it.
> How to sanitize?
As in your v2. :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
prev parent reply other threads:[~2023-05-29 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 8:16 [gentoo-dev] [PATCH] java-pkg-simple.eclass: respect SLOT="0" in JAVA_LAUNCHER_FILENAME Volkmar W. Pogatzki
2023-05-26 8:44 ` Ulrich Mueller
2023-05-29 7:13 ` Volkmar W. Pogatzki
2023-05-29 9:51 ` Ulrich Mueller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ua5xn1n42@gentoo.org \
--to=ulm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=gentoo@pogatzki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox