From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 6C105158086 for ; Sat, 8 Jan 2022 18:19:42 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 549A32BC032; Sat, 8 Jan 2022 18:19:22 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8C89E2BC01A for ; Sat, 8 Jan 2022 18:19:11 +0000 (UTC) From: Ulrich Mueller To: David Seifert Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/2] multibuild.eclass: remove dead userland_BSD In-Reply-To: <20220108173751.69375-1-soap@gentoo.org> (David Seifert's message of "Sat, 8 Jan 2022 18:37:50 +0100") References: <20220108173751.69375-1-soap@gentoo.org> Date: Sat, 08 Jan 2022 19:19:05 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: 09054dcb-3d93-4745-96d4-390c1ad94944 X-Archives-Hash: ab0ce379c8f7b9ef4c9c7841d12d6faf --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >>>>> On Sat, 08 Jan 2022, David Seifert wrote: =20 > + cp "${cp_args[@]}" "${src}"/. "${dest}"/ > + ret=3D${?} > + > if [[ ${ret} -ne 0 ]]; then > die "${MULTIBUILD_VARIANT:-(unknown)}: merging image failed." > fi This could be further simplified to "cp ... || die ..." (and no need to declare ret above). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmHZ1ZkPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uDnYH/jqfFjL+ua4GDsFEqrqkdLwBFLgDWZAdz2Nv Y20rOkIMqg27r/eUK0sAG3Mf4DsmVrzTA7kVA9nnvUEoNaWACrZxyza9Y1CtJPCk FYDBOcuyAXADHRtH2qdgcG+TBblhW7aHHS1qCGPH2gKvLiKGKikNod5RT9Mq//Vx U3jiDZTYV/OhyewB8udnjRsUj7ZSTCwD+hEi14aN3PumehMAegkVeQWnAtNhJIQQ cSd48tJu1jQRujdyEUFeZjeYsqaQi/Jf8Avlc97ZEKNI+nmZExBKG3wdgm8Pts6L 5f7/pslXtFTcyBozEsVkQAFIvATdcFZNpy+Dprj2ow2FnrQXpQ8= =NlVt -----END PGP SIGNATURE----- --=-=-=--