From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-101370-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 178D9158041
	for <garchives@archives.gentoo.org>; Fri,  1 Mar 2024 09:00:37 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 4137AE2A40;
	Fri,  1 Mar 2024 09:00:31 +0000 (UTC)
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id E78E5E2A2D
	for <gentoo-dev@lists.gentoo.org>; Fri,  1 Mar 2024 09:00:30 +0000 (UTC)
From: Ulrich Mueller <ulm@gentoo.org>
To: Florian Schmaus <flow@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org,  Paul Zander <negril.nx+gentoo@gmail.com>,
  tex@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/3] texlive-common.eclass: check exit
 status of texmf-update
In-Reply-To: <615944b5-426a-428d-9eb1-c9b0a5ab3699@gentoo.org> (Florian
	Schmaus's message of "Fri, 1 Mar 2024 09:47:42 +0100")
References: <20240229133839.292726-1-flow@gentoo.org>
	<20240229133839.292726-3-flow@gentoo.org> <uedcvovh8@gentoo.org>
	<615944b5-426a-428d-9eb1-c9b0a5ab3699@gentoo.org>
Date: Fri, 01 Mar 2024 10:00:20 +0100
Message-ID: <u7cimpbrv@gentoo.org>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
X-Archives-Salt: 93b559b2-01ca-4d8e-b89b-8afcd2b207bc
X-Archives-Hash: 94e6d1ea3b54ecfa767383548d81e873

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

>>>>> On Fri, 01 Mar 2024, Florian Schmaus wrote:

> On 29/02/2024 21.40, Ulrich Mueller wrote:
>>>>>>> On Thu, 29 Feb 2024, Florian Schmaus wrote:
>>=20
>>> @@ -178,6 +178,10 @@ etexmf-update() {
>>> if has_version 'app-text/texlive-core' ; then
>>> if [[ -z ${ROOT} && -x "${EPREFIX}"/usr/sbin/texmf-update ]] ; then
>>> "${EPREFIX}"/usr/sbin/texmf-update
>>> +			local res=3D"${?}"
>>> +			if [[ "${?}" -ne 0 ]] && ver_test -ge 2023; then
>> This condition will always be false.

> Is it because assigning 'res' will set '$?'?

Yes, the local command will return success status. So you should check
for ${res} not $?.

Ulrich

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmXhmSQPHHVsbUBnZW50
b28ub3JnAAoJEFGIM1CIQV4u42AH/2nvux187Pnk2ykcAR6vLJUua/O+AHzU7rrL
f61pgL585/6HvRGxDw4OLdISIBUII/OjERu+2NJVAlM6ZBG5CiBoU3NWPIUoKFIP
TxnzzWD7HudPbdUXGHlTv1wAoA6PGCJwCpUQv5XVxY/DISUe7GU1V1J4WJGsTuKu
OGoe4U1Pxab5HDHT+NzSnkQLdV4HjbSJym89DRQtRFOJR+soop4uVc9ZbSsq27ej
3BcQUf2A+P7F52ac+5Mt9s812VYE9jCGmZFgzeO7MnXgqRmYDmG3iXowcR2Gk8uq
875teBxtWDP+jCY91GVtBUVCpxJZX8+N0zjP3L/HwzIlmy+2bRU=
=2nuk
-----END PGP SIGNATURE-----
--=-=-=--