public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: Florian Schmaus <flow@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org,
	 Paul Zander <negril.nx+gentoo@gmail.com>,
	tex@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/3] texlive-common.eclass: check exit status of texmf-update
Date: Fri, 01 Mar 2024 10:00:20 +0100	[thread overview]
Message-ID: <u7cimpbrv@gentoo.org> (raw)
In-Reply-To: <615944b5-426a-428d-9eb1-c9b0a5ab3699@gentoo.org> (Florian Schmaus's message of "Fri, 1 Mar 2024 09:47:42 +0100")

[-- Attachment #1: Type: text/plain, Size: 644 bytes --]

>>>>> On Fri, 01 Mar 2024, Florian Schmaus wrote:

> On 29/02/2024 21.40, Ulrich Mueller wrote:
>>>>>>> On Thu, 29 Feb 2024, Florian Schmaus wrote:
>> 
>>> @@ -178,6 +178,10 @@ etexmf-update() {
>>> if has_version 'app-text/texlive-core' ; then
>>> if [[ -z ${ROOT} && -x "${EPREFIX}"/usr/sbin/texmf-update ]] ; then
>>> "${EPREFIX}"/usr/sbin/texmf-update
>>> +			local res="${?}"
>>> +			if [[ "${?}" -ne 0 ]] && ver_test -ge 2023; then
>> This condition will always be false.

> Is it because assigning 'res' will set '$?'?

Yes, the local command will return success status. So you should check
for ${res} not $?.

Ulrich

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

  reply	other threads:[~2024-03-01  9:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-29 13:38 [gentoo-dev] [PATCH 0/3] *** Three minor changes to texlive-(common|mmodule).elcass *** Florian Schmaus
2024-02-29 13:38 ` [gentoo-dev] [PATCH 1/3] texlive-module.eclass: implicitly set TL_PV if not explicitly set Florian Schmaus
2024-02-29 13:47   ` [gentoo-dev] " Florian Schmaus
2024-02-29 14:08     ` Michael Orlitzky
2024-02-29 14:21       ` Florian Schmaus
2024-02-29 14:34         ` Michael Orlitzky
2024-02-29 14:36           ` Florian Schmaus
2024-02-29 14:37         ` Michał Górny
2024-02-29 13:38 ` [gentoo-dev] [PATCH 2/3] texlive-common.eclass: check exit status of texmf-update Florian Schmaus
2024-02-29 20:40   ` Ulrich Mueller
2024-03-01  8:47     ` Florian Schmaus
2024-03-01  9:00       ` Ulrich Mueller [this message]
2024-02-29 13:38 ` [gentoo-dev] [PATCH 3/3] texlive-common.eclass: Use nonfatal-respecting die for fmtutil-sys Florian Schmaus
2024-02-29 14:38   ` Michał Górny
2024-02-29 20:37     ` Ulrich Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u7cimpbrv@gentoo.org \
    --to=ulm@gentoo.org \
    --cc=flow@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=negril.nx+gentoo@gmail.com \
    --cc=tex@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox