From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-94111-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 8FB701382C5
	for <garchives@archives.gentoo.org>; Wed, 31 Mar 2021 09:10:00 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 90E99E0822;
	Wed, 31 Mar 2021 09:09:56 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 505DCE075F
	for <gentoo-dev@lists.gentoo.org>; Wed, 31 Mar 2021 09:09:56 +0000 (UTC)
From: Ulrich Mueller <ulm@gentoo.org>
To: Andreas Sturmlechner <asturm@gentoo.org>
Cc: gentoo-dev <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in
 <EAPI-8, fix eclassdoc, make some funcs internal
In-Reply-To: <5252907.rdbgypaU67@tuxbook> (Andreas Sturmlechner's message of
	"Wed, 31 Mar 2021 08:39:27 +0200")
References: <5252907.rdbgypaU67@tuxbook>
Date: Wed, 31 Mar 2021 11:09:45 +0200
Message-ID: <u5z173d0m@gentoo.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.91 (gnu/linux)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
X-Archives-Salt: e6382438-a0c4-4633-a171-1ea8ce8301e7
X-Archives-Hash: 9aaa57cbd2af4b7185032957969488a9

--=-=-=
Content-Type: text/plain

>>>>> On Wed, 31 Mar 2021, Andreas Sturmlechner wrote:

>  setup-allowed-flags() {
> +	[[ ${EAPI} == [0-7] ]] ||
> +		die "Internal function ${FUNCNAME} is not available in >=EAPI-8."
> +	_setup-allowed-flags
> +}

Strictly speaking, EAPIs are strings, so numeric comparison is not
meaningful. Suggestion: "... is not available in EAPI ${EAPI}."

>  test-flag-PROG() {
> +	[[ ${EAPI} == [0-7] ]] ||
> +		die "Internal function ${FUNCNAME} is not available in >=EAPI-8."
> +	_test-flag-PROG
> +}

>  test-flags-PROG() {
> +	[[ ${EAPI} == [0-7] ]] ||
> +		die "Internal function ${FUNCNAME} is not available in >=EAPI-8."
> +	_test-flags-PROG
> +}

Same for these.

Ulrich

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmBkPFkPHHVsbUBnZW50
b28ub3JnAAoJEFGIM1CIQV4u0aQH/1IBI0cGNLck0eEtCPaLR+aNx14ggCWfxp6j
mGt65ofJ6Yf1tgzG2LOKtj7kiaKGT4Mj1coyxE4419CCk0++MNAESxWEY7vfsPNk
df5mnCaZOzLsfYmTrhkS6d9CKcRGMAlo9YsGD1AfuiWq9+cr0hV+bDDLVGoWCLHi
m8WP0d1Dlb4OrCq3s2kSatBWezXORB/ximZfnm8B/4sxRYuxaEPMwMz+8U6+vIar
tBH8oUj1HoWWOyZ3TjIkm88eyhJPFMBdkb1XFZEd1XTjXau+FzDOhxMpz8tO66ua
rgMtuFDx6dKlGbEWDWTYC7Qv7iuEE//LLEHiEab+VgLE98q3si0=
=XrwT
-----END PGP SIGNATURE-----
--=-=-=--