From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 604AB15817D for ; Thu, 13 Jun 2024 09:48:30 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 86514E2AF0; Thu, 13 Jun 2024 09:48:26 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3AA83E2AED for ; Thu, 13 Jun 2024 09:48:26 +0000 (UTC) From: Ulrich Mueller To: Florian Schmaus Cc: gentoo-dev@lists.gentoo.org, pacho@gentoo.org Subject: Re: [gentoo-dev] [PATCH v3 1/1] greadme.eclass: new eclass In-Reply-To: (Ulrich Mueller's message of "Thu, 13 Jun 2024 11:31:19 +0200") References: <20240613083928.165509-1-flow@gentoo.org> <20240613083928.165509-2-flow@gentoo.org> Date: Thu, 13 Jun 2024 11:48:21 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: 87e17118-0b1f-43c8-8ea3-c3f289a2f25a X-Archives-Hash: b5f635c0acad939239ed11f1cda9ab74 --=-=-= Content-Type: text/plain >>>>> On Thu, 13 Jun 2024, Ulrich Mueller wrote: >> + if $append; then > Please use the conventional coding style, i.e. ${append}. Or rather, assign the variable to empty or non-empty and test for [[ -n ${append} ]] instead of executing it as a true or false command. (I'm pretty sure that there was a previous discussion on this, but I fail to find it.) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmZqwGUPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uow0H/Ajx/OsLU8vn/3EuSGTb/efsa9P+hBbTDVw2 FF8QrRorv6UsW1Fjq4sC0LeeV+hc4y77G1n/T5miTq4uMuVdGj1uSyoS5o0MZXyw Y8k3Xy8iNpBAaC6G5yUGgBB1+5DnPljiJb61BZCaVkQTBuADvAzjV+rIN4HGkG/n CA44sOw9JKQPRKiFlSzShX0PuG6enfFKyf/KzMEWgz1WhQ2AjqUv7fTIq9nyC1lb 0N/EZTnv8M3AqTJDD0AjSPKv3hVVkfHksEim0GNT1DpR7CSKte87z3x1dDYTcYpW CFk3a8Dk2PqH9FKMne7oVoSKQwHxxUsBFkIf0fYR52yFp/11uZU= =q3Ak -----END PGP SIGNATURE----- --=-=-=--