From: Ulrich Mueller <ulm@gentoo.org>
To: Florian Schmaus <flow@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org, pacho@gentoo.org
Subject: Re: [gentoo-dev] [PATCH v3 1/1] greadme.eclass: new eclass
Date: Thu, 13 Jun 2024 11:48:21 +0200 [thread overview]
Message-ID: <u5xudtbq2@gentoo.org> (raw)
In-Reply-To: <ua5jptcig@gentoo.org> (Ulrich Mueller's message of "Thu, 13 Jun 2024 11:31:19 +0200")
[-- Attachment #1: Type: text/plain, Size: 359 bytes --]
>>>>> On Thu, 13 Jun 2024, Ulrich Mueller wrote:
>> + if $append; then
> Please use the conventional coding style, i.e. ${append}.
Or rather, assign the variable to empty or non-empty and test for
[[ -n ${append} ]] instead of executing it as a true or false command.
(I'm pretty sure that there was a previous discussion on this, but I
fail to find it.)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
next prev parent reply other threads:[~2024-06-13 9:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 8:39 [gentoo-dev] [PATCH v3 0/1] greadme.eclass: new eclass Florian Schmaus
2024-06-13 8:39 ` [gentoo-dev] [PATCH v3 1/1] " Florian Schmaus
2024-06-13 9:31 ` Ulrich Mueller
2024-06-13 9:48 ` Ulrich Mueller [this message]
2024-06-13 10:18 ` Florian Schmaus
2024-06-13 10:42 ` Ulrich Mueller
2024-06-13 10:57 ` Florian Schmaus
2024-06-13 11:59 ` [gentoo-dev] [PATCH v3 0/1] " Ionen Wolkens
2024-06-13 12:53 ` Florian Schmaus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u5xudtbq2@gentoo.org \
--to=ulm@gentoo.org \
--cc=flow@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=pacho@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox