From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id DCF3E15806E for ; Mon, 29 May 2023 09:54:24 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 944D2E0866; Mon, 29 May 2023 09:54:21 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2840EE0848 for ; Mon, 29 May 2023 09:54:21 +0000 (UTC) From: Ulrich Mueller To: "Volkmar W. Pogatzki" Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH v2] java-pkg-simple.eclass: respect SLOT="0" in JAVA_LAUNCHER_FILENAME In-Reply-To: <20230529072444.1296-1-gentoo@pogatzki.net> (Volkmar W. Pogatzki's message of "Mon, 29 May 2023 09:24:44 +0200") References: <20230529072444.1296-1-gentoo@pogatzki.net> Date: Mon, 29 May 2023 11:54:15 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: e071a685-ddb2-4196-b759-1b5c2042c945 X-Archives-Hash: 98d2c68aef5ea945bba6ed910629014b --=-=-= Content-Type: text/plain >>>>> On Mon, 29 May 2023, Volkmar W Pogatzki wrote: > +if [[ ${SLOT} = 0 ]]; then > +: "${JAVA_LAUNCHER_FILENAME:=${PN}}" > +else > : "${JAVA_LAUNCHER_FILENAME:=${PN}-${SLOT}}" > +fi Please indent the lines in the then and else blocks. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmR0dkcPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4u2v8H/RJni3onjNY1Xuc6hM8J072KBqjK2YQ+R5jA Hkbzn84KjrHTIWV7ncXR/IjTaN3YWhiGKrMHPKWS1Z0SroLj+CFPQApuS16f7U+2 XBlaUA8MdgcufxnUfcMSTfO27KqSUKrrM2bwlef0GtqEfIH2Nat17UXSlZI/vh1W H8ZIUGrCRNha1UuvGQLr23TUeYvTAAtgGvY0CKMymqTHznsOWdhcMR3Pv8J3mRs3 1l32kFBSvEfkPtIrXn3oS7+2TXFOaRPuC4g6JSdbfRTqSX2wcultO/EhufRJEs8R nr11oB08LhiQYp2ZvwkV+Z2HRzM2cbrnRp/vEnhbQ9cKCCqj/6w= =GKDE -----END PGP SIGNATURE----- --=-=-=--