* [gentoo-dev] [PATCH v2] java-pkg-simple.eclass: respect SLOT="0" in JAVA_LAUNCHER_FILENAME
@ 2023-05-29 7:24 Volkmar W. Pogatzki
2023-05-29 9:54 ` Ulrich Mueller
0 siblings, 1 reply; 2+ messages in thread
From: Volkmar W. Pogatzki @ 2023-05-29 7:24 UTC (permalink / raw
To: gentoo-dev
Avoids the need for setting JAVA_LAUNCHER_FILENAME="${PN}" if SLOT is 0.
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
---
eclass/java-pkg-simple.eclass | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/eclass/java-pkg-simple.eclass b/eclass/java-pkg-simple.eclass
index 929ce68c6c07..a57fae02ffd7 100644
--- a/eclass/java-pkg-simple.eclass
+++ b/eclass/java-pkg-simple.eclass
@@ -161,7 +161,11 @@ fi
# If ${JAVA_MAIN_CLASS} is set, we will create a launcher to
# execute the jar, and ${JAVA_LAUNCHER_FILENAME} will be the
# name of the script.
+if [[ ${SLOT} = 0 ]]; then
+: "${JAVA_LAUNCHER_FILENAME:=${PN}}"
+else
: "${JAVA_LAUNCHER_FILENAME:=${PN}-${SLOT}}"
+fi
# @ECLASS_VARIABLE: JAVA_TESTING_FRAMEWORKS
# @DEFAULT_UNSET
--
2.39.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [gentoo-dev] [PATCH v2] java-pkg-simple.eclass: respect SLOT="0" in JAVA_LAUNCHER_FILENAME
2023-05-29 7:24 [gentoo-dev] [PATCH v2] java-pkg-simple.eclass: respect SLOT="0" in JAVA_LAUNCHER_FILENAME Volkmar W. Pogatzki
@ 2023-05-29 9:54 ` Ulrich Mueller
0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Mueller @ 2023-05-29 9:54 UTC (permalink / raw
To: Volkmar W. Pogatzki; +Cc: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
>>>>> On Mon, 29 May 2023, Volkmar W Pogatzki wrote:
> +if [[ ${SLOT} = 0 ]]; then
> +: "${JAVA_LAUNCHER_FILENAME:=${PN}}"
> +else
> : "${JAVA_LAUNCHER_FILENAME:=${PN}-${SLOT}}"
> +fi
Please indent the lines in the then and else blocks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-29 9:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-29 7:24 [gentoo-dev] [PATCH v2] java-pkg-simple.eclass: respect SLOT="0" in JAVA_LAUNCHER_FILENAME Volkmar W. Pogatzki
2023-05-29 9:54 ` Ulrich Mueller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox