From: Ulrich Mueller <ulm@gentoo.org>
To: Mike Gilbert <floppym@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v2] verify-sig.eclass: avoid calling unpack on sig files
Date: Wed, 22 May 2024 07:53:47 +0200 [thread overview]
Message-ID: <u1q5u75p0@gentoo.org> (raw)
In-Reply-To: <20240522020519.1845786-1-floppym@gentoo.org> (Mike Gilbert's message of "Tue, 21 May 2024 22:05:19 -0400")
[-- Attachment #1: Type: text/plain, Size: 959 bytes --]
>>>>> On Wed, 22 May 2024, Mike Gilbert wrote:
> Signed-off-by: Mike Gilbert <floppym@gentoo.org>
> ---
> eclass/verify-sig.eclass | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
> diff --git a/eclass/verify-sig.eclass b/eclass/verify-sig.eclass
> index b74ed78290aa..4d48c9ed8503 100644
> --- a/eclass/verify-sig.eclass
> +++ b/eclass/verify-sig.eclass
> @@ -426,10 +426,14 @@ verify-sig_src_unpack() {
> verify-sig_verify_detached \
> "${DISTDIR}/${f%.*}" "${DISTDIR}/${f}"
> done
> - fi
> - # finally, unpack the distfiles
> - default_src_unpack
> + # finally, unpack the distfiles
> + if [[ ${#distfiles[@]} -gt 0 ]]; then
> + unpack "${distfiles[@]}"
> + fi
> + else
> + default_src_unpack
> + fi
> }
> fi
Please provide an explanation what problem this patch fixes.
Why is calling unpack on sig files bad? It should silently skip files
with unknown extensions.
Ulrich
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
next prev parent reply other threads:[~2024-05-22 5:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 1:58 [gentoo-dev] [PATCH] verify-sig.eclass: avoid calling unpack on sig files Mike Gilbert
2024-05-22 2:05 ` [gentoo-dev] [PATCH v2] " Mike Gilbert
2024-05-22 3:38 ` Michał Górny
2024-05-22 14:59 ` Mike Gilbert
2024-05-22 5:53 ` Ulrich Mueller [this message]
2024-05-22 14:55 ` Mike Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u1q5u75p0@gentoo.org \
--to=ulm@gentoo.org \
--cc=floppym@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox