public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Martin Vaeth <martin@mvath.de>
To: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] Re: Requirements for UID/GID management
Date: Fri, 3 Feb 2017 14:51:53 +0000 (UTC)	[thread overview]
Message-ID: <slrno9968g.p7t.martin@lounge.imp.fu-berlin.de> (raw)
In-Reply-To: 671d81bc-8432-a903-024f-40e3c19a4f96@gentoo.org

Michael Orlitzky <mjo@gentoo.org> wrote:
>
> The fact that all permission and ownership information is shared is
> precisely the problem. When you change ownership of the hardlink (which
> you'll never know is a hardlink), you change ownership of /etc/shadow.

Why should this be a problem except for a race between reading
and changing the ownership?
Admittedly, by using "find ... -exec ... +" the time for an exploit
of the race is even increased when a "standard" chown command is used.

However, it is no rocket science to write a race-free chown command
in C: Just open the file and use stat() and fchown() to be sure to
change only files from the "correct" user.

Since this works on the filehandle and not on the filename, I think
that there is no possibility for an exploit when this is used in the
above find loop.



  parent reply	other threads:[~2017-02-03 14:52 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27 17:54 [gentoo-dev] Requirements for UID/GID management Michael Orlitzky
2017-01-27 18:19 ` Alexis Ballier
2017-01-27 18:52 ` Rich Freeman
2017-01-27 19:35   ` Michael Orlitzky
2017-01-27 19:53     ` Rich Freeman
2017-01-27 20:09       ` Michael Orlitzky
2017-01-27 21:23         ` Rich Freeman
2017-01-28  3:02           ` [gentoo-dev] " Duncan
2017-01-28  2:37       ` [gentoo-dev] " Patrick McLean
2017-01-28  3:20         ` Michael Orlitzky
2017-01-28  4:21         ` Rich Freeman
2017-01-29  1:56           ` Michael Orlitzky
2017-01-29  2:22             ` Rich Freeman
2017-01-29  2:48               ` Michael Orlitzky
2017-01-29  2:54               ` Michael Orlitzky
2017-01-29  3:23                 ` Gordon Pettey
2017-01-29  3:36                   ` M. J. Everitt
2017-01-29  3:42                   ` Michael Orlitzky
2017-01-29 10:03                     ` Ulrich Mueller
2017-01-29 11:16                       ` Michał Górny
2017-01-29 17:19                       ` Michael Orlitzky
2017-01-29  3:05             ` M. J. Everitt
2017-01-29  8:26             ` Alan McKinnon
2017-01-29 17:05               ` Michael Orlitzky
2017-01-29 17:22                 ` A. Wilcox
2017-01-29 19:31                   ` james
2017-01-29 22:07                 ` Alan McKinnon
2017-01-29 22:20                   ` Michael Orlitzky
2017-01-29 22:30                     ` Alan McKinnon
2017-01-29 23:04                       ` Michael Orlitzky
2017-01-30 14:25                         ` Alan McKinnon
2017-01-30 16:29                           ` Michael Orlitzky
2017-01-30 18:05                             ` Patrick McLean
2017-01-30 18:22                               ` Michael Orlitzky
2017-01-30 18:43                                 ` Kristian Fiskerstrand
2017-02-03 14:51                                 ` Martin Vaeth [this message]
2017-02-03 19:29                                   ` [gentoo-dev] " Michael Orlitzky
2017-02-04  8:50                                     ` Christopher Head
2017-02-04 15:02                                       ` Michael Orlitzky
2017-02-04 18:03                                       ` Martin Vaeth
2017-01-28 11:28         ` [gentoo-dev] " James Le Cuirot
2017-01-28 22:54           ` Patrick McLean
2017-01-28 18:13         ` A. Wilcox
2017-01-28 19:32           ` James Le Cuirot
2017-01-28 20:34             ` Rich Freeman
2017-01-28 21:29               ` James Le Cuirot
2017-01-29 17:16             ` A. Wilcox
2017-01-29 17:34               ` James Le Cuirot
2017-01-27 19:45   ` Gregory Woodbury
2017-01-28 11:32   ` Tom H
2017-01-27 21:15 ` Michał Górny
2017-01-28  0:10   ` Michael Orlitzky
2017-01-29 22:13 ` Michael Orlitzky
2017-01-29 23:34   ` Ulrich Mueller
2017-01-29 23:45     ` Michael Orlitzky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=slrno9968g.p7t.martin@lounge.imp.fu-berlin.de \
    --to=martin@mvath.de \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox