From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 84693158041 for ; Mon, 26 Feb 2024 09:47:06 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2FD66E29DA; Mon, 26 Feb 2024 09:47:01 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id AE6F6E29D5 for ; Mon, 26 Feb 2024 09:47:00 +0000 (UTC) Received: from grubbs.orbis-terrarum.net (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 247D133BEBE for ; Mon, 26 Feb 2024 09:47:00 +0000 (UTC) Received: from grubbs.orbis-terrarum.net (localhost [127.0.0.1]) by grubbs.orbis-terrarum.net (Postfix) with ESMTP id 8C9572601A2 for ; Mon, 26 Feb 2024 09:46:59 +0000 (UTC) Received: (qmail 31961 invoked by uid 10000); 26 Feb 2024 09:46:59 -0000 Date: Mon, 26 Feb 2024 09:46:59 +0000 From: "Robin H. Johnson" To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH v2 1/2] check-reqs.eclass: runtime disk checks for any path. Message-ID: References: <20240219220832.25919-1-robbat2@gentoo.org> <20240226063105.1767-1-robbat2@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TVlH8PkDwfPk5c/z" Content-Disposition: inline In-Reply-To: X-Archives-Salt: 34162612-51c3-4c36-9ba2-091d10fb275a X-Archives-Hash: 39b82c6b12875ffa7aabd2f98d6eca27 --TVlH8PkDwfPk5c/z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 26, 2024 at 08:01:28AM +0100, zzam@gentoo.org wrote: > Am 26.02.24 um 07:31 schrieb Robin H. Johnson: > > Allow checking any runtime path for installing ever-larger packages. > >=20 > > CHECKREQS_DISK_RUNTIME=3D( /boot:40M /:350M /opt:500M ) >=20 > In the example case: Shouldn't the eclass check for 850M on / if /opt is= =20 > not a separate partition? > I am not sure how often it really happens that multiple large=20 > requirements for different folders exist. I just summed up the 2 example packages here. I do see your concern about the filesystem/mountpoint layout. If it's a single /: that needs 850M If it's split / and /opt: then it's the listed space in each location. Correctly processing this would require converting each of the listed check locations to their common mounts, summing the needs, and then validating. This should be possible with "stat --printf=3D%m" to resolve any directory into it's mountpoint. I'll see if it can be done trivially enough for the eclass. --=20 Robin Hugh Johnson Gentoo Linux: Dev, Infra Lead, Foundation President & Treasurer E-Mail : robbat2@gentoo.org GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136 --TVlH8PkDwfPk5c/z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Robbat2 @ Orbis-Terrarum Networks - The text below is a digital signature. If it doesn't make any sense to you, ignore it. iQKTBAABCgB9FiEEveu2pS8Vb98xaNkRGTlfI8WIJsQFAmXcXhFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEJE RUJCNkE1MkYxNTZGREYzMTY4RDkxMTE5Mzk1RjIzQzU4ODI2QzQACgkQGTlfI8WI JsQjmA/+P4f2oCOYOpyFEUhZN7OKKCHxIg0wdZn417QkHR0O1Xq+7gXUcmi9kP12 11+LX5aBO5dM4sXvCjzLF1Ncx3M5a+bVPxbJ8hrvp18WjN6nxTjnRV3LVkvTD/Dy 0Ct6SXb+lxWSslf5z7bBJpuYhiXGI0Rsix6pQDwgeCKkAEH2a7Jy7UuLkQJz6ccS gGN0K216i8EW7C955LaSwQeVhuKtzk591uU7b5NvBVgm9zquLJHTbZLcVtG9hFLC AwgbgC7Wpppuuy0Ve3vXZdyp2i/kBpjNYoVbmN+YbfOykgwx6xVz8vogsa1dvNFM 80ON9xH8hFtXn2T8/naK4eEfTHBUdZc5Ryu/C0yz1jOPt4O+0jKXmlawJqNAbpKt MGdrL3+JPu8+O2a3IrfAxivxxy0d05ykZm6f2QpO7deVsT7RHa+YUwsFFi31g8M9 fuk4CLv9gUYr/cOdl9wr2DpepbQECrDVgo/MDSmNDH8dJ2VxmWVNNrtvXWrOjfoO xujdBrB5g78oswShgZTmKMEe+C7BE6si6zzK+nvqtX+TIyPZYrOxIHQXu3VLL/sM phwYCGIL/PCXe7TLLYc/cKxqot2iM9lPLMm2NHBmdRzSnTOXNstsMrVSWsrSi+89 TeTEbKC38koN77eEOvOC8xQX19qajpJBTXIziC/d+FWFLfxVf4I= =Bzkg -----END PGP SIGNATURE----- --TVlH8PkDwfPk5c/z--